Fix of #229 (PsGithub sends invalid POST request)

[cyberone]

Fix of #229 (PsGithub sends invalid POST request)

1. Removed request parameters from URI
2. Added request parameters to request body

[davvd]

@cyberone Thanks, I will find someone to review this PR soon

[davvd]

@carlosmiranda review this one, please

[carlosmiranda]

@cyberone Shouldn't there be a unit test that replicates the bug for this?

[cyberone]

@carlosmiranda there's already an issue #42 about missing test on PsGithub.

[carlosmiranda]

@cyberone In that case you should add a puzzle to test this particular scenario. We can't leave it as it is, or nobody will notice and your change will be untested.

[cyberone]

@carlosmiranda added puzzle. Please re-check.

[carlosmiranda]

@cyberone Where is the estimated time? Should be (for example) #229:30min.

[carlosmiranda]

@cyberone A couple of comments related to the puzzle above.

[cyberone]

@carlosmiranda done

[carlosmiranda]

@cyberone Thanks!

[carlosmiranda]

@rultor merge please

[rultor]

@rultor merge please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 11min)

[davvd]

@elenavolokhova please, review this task for compliance with our quality rules

[davvd]

@rultor deploy pls

[rultor]

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 7min)

[elenavolokhova]

@carlosmiranda
According to our quality rules:

Pull request title explains the problem it is fixing.

The title of this request doesn't contain such information. As far as you are the performer of this ticket you are responsible for its quality.
Please fix this issue and make sure that everyone follows this rule in your tickets in the future.

According to our quality rules:

Comments were mostly about design problems, not cosmetic issues.

There were mostly cosmetic issues found during review. Try to pay attention to bigger design problems and the overall quality of the code.
Please confirm that this new rule is clear.

[carlosmiranda]

@cyberone please rename the ticket title to reflect the actual problem as requested by @elenavolokhova .

[cyberone]

@carlosmiranda done.

[elenavolokhova]

@cyberone Thank you

[elenavolokhova]

@davvd Quality is acceptable.

[davvd]

@davvd Quality is acceptable.

@elenavolokhova thanks for the review, we'll try better next time

[davvd]

@davvd Quality is acceptable.

@elenavolokhova thank you, let's try to make it "good" next time

[davvd]

@carlosmiranda I added 10 mins to @elenavolokhova (for QA review) in transaction 56879541

I just added 21 mins to your account, many thanks for your contribution.. 56879557 spent here

you're getting extra minutes here (c=6)

+21 added to your rating, current score is: +4501