11: Pass for Twitter added. #175

popprem · 2015-04-15T10:46:13Z

Pass for twitter added. Todo: PsTwitterTest has to be implemented or XeTwitterLink & XeTwitterLinkTest have to be implemented which will test PsTwitter too.

PR #175 for issue #11.

davvd · 2015-04-15T12:51:24Z

@popprem Thanks, I will find someone to review this PR soon

davvd · 2015-04-15T13:04:01Z

@longtimeago please review,thanks

longtimeago · 2015-04-15T17:43:04Z

pom.xml

@@ -136,6 +136,11 @@
            <optional>true</optional>
        </dependency>
        <dependency>
+		    <groupId>commons-codec</groupId>


@popprem we are not allowed to use external dependency with compile scope. We promised that to our clients.
javax.xml.bind.DatatypeConverter should help

longtimeago · 2015-04-15T18:28:15Z

@popprem thanks for the PR. See several remarks above

popprem · 2015-04-16T02:21:26Z

@longtimeago Thanks for the review, have addressed the issues. Please check.

longtimeago · 2015-04-17T06:42:31Z

@popprem Now we are good to go, thank you!

longtimeago · 2015-04-17T06:42:37Z

@rultor merge please

rultor · 2015-04-17T06:42:57Z

@rultor merge please

@longtimeago Thanks for your request. @yegor256 Please confirm this.

longtimeago · 2015-04-17T06:50:55Z

@popprem looks like I've missed to note one important thing ... no tests ?? Please, add at least one. Yegor will not leave out this PR without test

popprem · 2015-04-17T18:45:46Z

@longtimeago Yes, I have commented the same on the pull request. Test for PsTwitter is not straightforward ,should be done with oauth mocks etc. Need advise on the same.

longtimeago · 2015-04-17T18:59:02Z

@popprem yep ... I see the comment. Add at least todo in the code. Other developer will implement it

popprem · 2015-04-18T17:15:42Z

@longtimeago Test added with todo comment, please check.

longtimeago · 2015-04-18T17:35:58Z

@popprem Todo must be formatted as puzzle (see examples https://github.com/teamed/pdd)
@todo #11:30min What actually to be done
Description should be meaningful, more that 20 words. New task will be generated by this todo with description you provided. So, please, put there as much details as possible to avoid questions from next developer. Imagine, you are the developer and will get the task, generated by this todo. What would you like to be mentioned there?

popprem · 2015-04-18T20:29:19Z

@longtimeago Test description updated with proper todo format. Please verify.

yegor256 · 2015-04-20T18:57:20Z

@popprem I still don't understand why do you use 8 indentation spaces sometimes and sometimes 4. what is the message here? what are you trying to say by 8 spaces? also, read this: http://www.yegor256.com/2014/10/23/paired-brackets-notation.html

popprem · 2015-04-21T09:50:15Z

@yegor256 Looks cleaner now, please verify.

yegor256 · 2015-04-22T03:32:21Z

@rultor merge

rultor · 2015-04-22T03:35:30Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-04-22T03:37:15Z

@rultor merge

@yegor256 Oops, I failed. You can see the full log here (spent 1min)

Auto-merging src/main/java/org/takes/rs/RsXSLT.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/rs/RsXSLT.java
Auto-merging src/main/java/org/takes/rs/xe/XeLinkHome.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/rs/xe/XeLinkHome.java
Auto-merging src/main/java/org/takes/rs/xe/XeLinkSelf.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/rs/xe/XeLinkSelf.java
Auto-merging src/main/java/org/takes/tk/TkMeasured.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/tk/TkMeasured.java
Auto-merging src/main/java/org/takes/tk/TkVerbose.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/tk/TkVerbose.java
Auto-merging src/main/java/org/takes/tk/TkVersioned.java
CONFLICT (add/add): Merge conflict in src/main/java/org/takes/tk/TkVersioned.java
Auto-merging src/test/java/org/takes/facets/auth/PsByFlagTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/auth/PsByFlagTest.java
Auto-merging src/test/java/org/takes/facets/auth/TkAuthTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/auth/TkAuthTest.java
Auto-merging src/test/java/org/takes/facets/auth/codecs/CcHexTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/auth/codecs/CcHexTest.java
Auto-merging src/test/java/org/takes/facets/fallback/TkFallbackTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fallback/TkFallbackTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkAnonymousTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkAnonymousTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkAuthenticatedTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkAuthenticatedTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkEncodingTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkEncodingTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkHitRefreshTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkHitRefreshTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkMethodsTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkMethodsTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkParamsTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkParamsTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkRegexTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkRegexTest.java
Auto-merging src/test/java/org/takes/facets/fork/FkTypesTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/fork/FkTypesTest.java
Auto-merging src/test/java/org/takes/facets/forward/TkForwardTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/facets/forward/TkForwardTest.java
Auto-merging src/test/java/org/takes/http/FtCLITest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/http/FtCLITest.java
Auto-merging src/test/java/org/takes/misc/HrefTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/misc/HrefTest.java
Auto-merging src/test/java/org/takes/rq/RqCookiesTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rq/RqCookiesTest.java
Auto-merging src/test/java/org/takes/rq/RqFormTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rq/RqFormTest.java
Auto-merging src/test/java/org/takes/rq/RqHrefTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rq/RqHrefTest.java
Auto-merging src/test/java/org/takes/rq/RqMethodTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rq/RqMethodTest.java
Auto-merging src/test/java/org/takes/rq/RqMultipartTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rq/RqMultipartTest.java
Auto-merging src/test/java/org/takes/rs/RsWithCookieTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/rs/RsWithCookieTest.java
Auto-merging src/test/java/org/takes/tk/TkMeasuredTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/tk/TkMeasuredTest.java
Auto-merging src/test/java/org/takes/tk/TkVersionedTest.java
CONFLICT (add/add): Merge conflict in src/test/java/org/takes/tk/TkVersionedTest.java
Automatic merge failed; fix conflicts and then commit the result.

longtimeago · 2015-04-22T07:26:15Z

@popprem please, merge from master

popprem · 2015-04-25T10:51:54Z

@longtimeago Have merged from master. Please try merging.

longtimeago · 2015-04-25T17:54:46Z

@rultor please merge

rultor · 2015-04-25T17:55:10Z

@rultor please merge

@longtimeago Thanks for your request. @yegor256 Please confirm this.

popprem · 2015-04-28T03:16:55Z

@yegor256 Can this be merged please?

yegor256 · 2015-04-29T04:31:07Z

@rultor merge

rultor · 2015-04-29T04:32:44Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-04-29T04:44:17Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

popprem · 2015-04-29T13:42:02Z

@davvd @yegor256 Can this be closed please?

yegor256 · 2015-04-29T17:10:38Z

@popprem it is closed already

davvd · 2015-04-30T09:37:37Z

@elenavolokhova review this ticket please, for compliance with our quality rules

davvd · 2015-04-30T09:40:05Z

@rultor deploy pls

rultor · 2015-04-30T09:40:20Z

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

rultor · 2015-04-30T09:47:57Z

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 8min)

elenavolokhova · 2015-05-04T08:22:29Z

@longtimeago
Please fix description of this PR. Pull request description should explain the solution proposed and contains a link to the original ticket it is related to.

popprem · 2015-05-04T18:07:02Z

@elenavolokhova Added link to the original ticket.

elenavolokhova · 2015-05-05T05:17:58Z

@popprem Thank you!

elenavolokhova · 2015-05-05T05:18:13Z

@davvd Quality is acceptable

davvd · 2015-05-05T18:02:41Z

@davvd Quality is acceptable

@elenavolokhova thanks for the review, we'll try better next time

davvd · 2015-05-06T10:45:07Z

@davvd Quality is acceptable

@elenavolokhova thanks a lot, next time everybody should try to make it better

davvd · 2015-05-09T11:03:57Z

@longtimeago I added 10 mins to @elenavolokhova (for QA review) in transaction 56850215... Thanks a lot, I just topped your account for 26 mins, transaction ID 56850223, total time was 332 hours and 21 mins... you're getting extra minutes here (c=11)... +26 to your rating, your total score is +4581

popprem added 3 commits April 15, 2015 16:09

11: Pass for Twitter added.

9997608

11: Pass for Twitter added.

0b84c20

11: Pass for Twitter added.

06863fb

davvd added CR @longtimeago labels Apr 15, 2015

popprem mentioned this pull request Apr 15, 2015

PsTwitter #11

Closed

longtimeago reviewed Apr 15, 2015
View reviewed changes

yegor256#11: Review comments addressed

dc682e4

yegor256#11: PsTwitter test added.

f15d203

popprem added 3 commits April 19, 2015 01:45

yegor256#11: PsTwitterTest todo description updated

fb36131

yegor256#11: PsTwitterTest todo description updated

013acab

yegor256#11: PsTwitterTest todo description updated

2cebe53

yegor256#11: indentation updated

eb2c44e

Merge branch 'master' into 11

dfb4c64

rultor merged commit dfb4c64 into yegor256:master Apr 29, 2015

popprem deleted the 11 branch April 29, 2015 13:36

11: Pass for Twitter added. #175

11: Pass for Twitter added. #175

Conversation

popprem commented Apr 15, 2015

davvd commented Apr 15, 2015

davvd commented Apr 15, 2015

longtimeago Apr 15, 2015

Choose a reason for hiding this comment

longtimeago commented Apr 15, 2015

popprem commented Apr 16, 2015

longtimeago commented Apr 17, 2015

longtimeago commented Apr 17, 2015

rultor commented Apr 17, 2015

longtimeago commented Apr 17, 2015

popprem commented Apr 17, 2015

longtimeago commented Apr 17, 2015

popprem commented Apr 18, 2015

longtimeago commented Apr 18, 2015

popprem commented Apr 18, 2015

yegor256 commented Apr 20, 2015

popprem commented Apr 21, 2015

yegor256 commented Apr 22, 2015

rultor commented Apr 22, 2015

rultor commented Apr 22, 2015

longtimeago commented Apr 22, 2015

popprem commented Apr 25, 2015

longtimeago commented Apr 25, 2015

rultor commented Apr 25, 2015

popprem commented Apr 28, 2015

yegor256 commented Apr 29, 2015

rultor commented Apr 29, 2015

rultor commented Apr 29, 2015

popprem commented Apr 29, 2015

yegor256 commented Apr 29, 2015

davvd commented Apr 30, 2015

davvd commented Apr 30, 2015

rultor commented Apr 30, 2015

rultor commented Apr 30, 2015

elenavolokhova commented May 4, 2015

popprem commented May 4, 2015

elenavolokhova commented May 5, 2015

elenavolokhova commented May 5, 2015

davvd commented May 5, 2015

davvd commented May 6, 2015

davvd commented May 9, 2015