Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1080) Uses Sticky in RqOnce in place of inner anonymous class #1093

Merged
merged 7 commits into from
Jan 18, 2022

Conversation

baudoliver7
Copy link
Contributor

For #1080

  • Use Sticky in place of inner anonymous class

src/main/java/org/takes/rq/RqOnce.java Outdated Show resolved Hide resolved
src/main/java/org/takes/rq/RqOnce.java Outdated Show resolved Hide resolved
@baudoliver7 baudoliver7 force-pushed the use_sticky_decorator branch from 6b68970 to 15ba8d6 Compare March 1, 2021 06:21
@baudoliver7
Copy link
Contributor Author

@andreoss Please, see my changes.

src/main/java/org/takes/rq/RqOnce.java Outdated Show resolved Hide resolved
@baudoliver7
Copy link
Contributor Author

@andreoss RequestOf ctor with Scalar arguments has been removed from master branch. So, I introduced a new puzzle that requests creation of two decorators HeadOnce and BodyOnce to resolve this issue. WDYT ?

@baudoliver7
Copy link
Contributor Author

@andreoss ping

@baudoliver7
Copy link
Contributor Author

@andreoss Please, could you check the last changes and my last comment ?

@andreoss
Copy link
Contributor

andreoss commented May 5, 2021

@baudoliver7 May be we should wait for #1104?

@baudoliver7
Copy link
Contributor Author

@andreoss PR is now ready to be reviewed :)

@baudoliver7
Copy link
Contributor Author

@andreoss AppVeyor ci fails because of maven link broken. I reported it to issue #1111

@baudoliver7
Copy link
Contributor Author

@andreoss please, take a look to the latest changes.

@baudoliver7
Copy link
Contributor Author

@andreoss ping

@baudoliver7
Copy link
Contributor Author

@yegor256 could you merge this, please ?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 18, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 90d4ce7 into yegor256:master Jan 18, 2022
@rultor
Copy link
Collaborator

rultor commented Jan 18, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

@baudoliver7 baudoliver7 deleted the use_sticky_decorator branch January 18, 2022 08:02
@0crat 0crat added qa and removed 0crat/scope labels Feb 20, 2022
@0crat
Copy link
Collaborator

0crat commented Feb 20, 2022

@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2022

Code review was too long (356 days), architects (@paulodamaso) were penalized, see §55

@sereshqua
Copy link

@0crat quality good

@0crat 0crat added quality/good and removed qa labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants