Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RsWithStatus.java:97-101: To implement concatenation and selection... #276

Closed
davvd opened this issue May 10, 2015 · 8 comments
Closed

RsWithStatus.java:97-101: To implement concatenation and selection... #276

davvd opened this issue May 10, 2015 · 8 comments

Comments

@davvd
Copy link

davvd commented May 10, 2015

Puzzle 160-fc7f658c in src/main/java/org/takes/rs/RsWithStatus.java:97-101 has to be resolved: To implement concatenation and selection with the conjunction Concat and Select class to get rid of List.add() between line 118 to line 127. That is, replacing the block using something like this: return new Concat(head,new Select(origin.head(),new FilterFirstCond()))... The puzzle was created by super132 on 8-May-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented May 10, 2015

@dmzaytsev the task is yours, please go ahead

@dmzaytsev
Copy link
Contributor

@davvd please see PR #280

@davvd
Copy link
Author

davvd commented May 11, 2015

@yegor256 I set milestone here to 1.0, let me know if it is wrong

@davvd davvd added this to the 1.0 milestone May 11, 2015
@davvd
Copy link
Author

davvd commented May 11, 2015

@davvd please see PR #280

@dmzaytsev thanks, will take a look

dmzaytsev added a commit to dmzaytsev/takes that referenced this issue May 13, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue May 13, 2015
@dmzaytsev
Copy link
Contributor

@davvd PR #280 fixes this issue and merged successfully. Could you please close this ticket? Thanks.

@dmzaytsev
Copy link
Contributor

@davvd close the task please

@davvd
Copy link
Author

davvd commented May 15, 2015

@yegor256 It is closed now

@davvd davvd closed this as completed May 15, 2015
@davvd
Copy link
Author

davvd commented May 15, 2015

@dmzaytsev Thanks for your contribution, 30 mins was added to your account, payment ID is 57310622, 86 hours and 18 mins spent total

+30 to your rating, your total score is +1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants