Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PsTwitterTest.java:42-47: Test to be implemented for... #230

Closed
davvd opened this issue Apr 30, 2015 · 27 comments
Closed

PsTwitterTest.java:42-47: Test to be implemented for... #230

davvd opened this issue Apr 30, 2015 · 27 comments

Comments

@davvd
Copy link

davvd commented Apr 30, 2015

Puzzle 11-790c0445 in src/test/java/org/takes/facets/auth/social/PsTwitterTest.java:42-47 has to be resolved: Test to be implemented for PsTwitter using a oauth mock library (eg:wiremock). Need to modify PsTwitter to accept url from configurations, so that url can be changed for test and real env accordingly. Response to be stubbed for both token and verify_credentials calls and assertions to be performed for the values returned.... The puzzle was created by Prasath Premkumar on 20-Apr-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented Apr 30, 2015

@ikhvostenkov please go ahead with this task,it's yours

@davvd davvd added this to the 1.0 milestone Apr 30, 2015
@davvd
Copy link
Author

davvd commented Apr 30, 2015

@yegor256 there is no milestone yet, so I set it to 1.0

@ikhvostenkov
Copy link
Contributor

@davvd Could you please assign someone else to this task?

@davvd
Copy link
Author

davvd commented May 12, 2015

@davvd Could you please assign someone else to this task?

@ikhvostenkov 30 points deducted from your rating

@davvd
Copy link
Author

davvd commented May 12, 2015

@davvd Could you please assign someone else to this task?

@ikhvostenkov got it, someone else will be assigned soon

@davvd
Copy link
Author

davvd commented May 12, 2015

@YamStranger please go ahead with this task, it's yours

@YamStranger
Copy link
Contributor

@davvd Thanks

@YamStranger
Copy link
Contributor

@davvd Please help me. I don't understand this words "Puzzle 11-790c0445" what is "11-790c0445"? Is this some id of puzzle specification, of something else?

@yegor256
Copy link
Owner

@YamStranger yes, it's just an id of the puzzle

@YamStranger
Copy link
Contributor

@yegor256 Can I get some info about this puzzle, by this id? Where can I find this info, if it is possible?

@yegor256
Copy link
Owner

@YamStranger what kind of info do you need? everything you need (and we have) is in the Java file

@YamStranger
Copy link
Contributor

@yegor256 Thanks. It was info what I need. This is just id, and it will be not useful for me (I cant use it any way)

@YamStranger
Copy link
Contributor

@davvd , @yegor256. As wrote @alice, I am not with your team any more. So please assign ticket to someone else. Thanks

@davvd
Copy link
Author

davvd commented May 17, 2015

@davvd , @yegor256. As wrote @alice, I am not with your team any more. So please assign ticket to someone else. Thanks

@YamStranger OK, I will try to assign someone else

@davvd
Copy link
Author

davvd commented May 18, 2015

@adko-pl please proceed, it's yours

@davvd davvd added the @adko-pl label May 18, 2015
adamsiemion added a commit to adamsiemion/takes that referenced this issue May 23, 2015
@adamsiemion
Copy link
Contributor

@davvd Can I get an extension on this ticket? I need to fix code review comments.

adamsiemion pushed a commit to adamsiemion/takes that referenced this issue Jun 8, 2015
adamsiemion added a commit to adamsiemion/takes that referenced this issue Jun 8, 2015
@yegor256
Copy link
Owner

yegor256 commented Jun 8, 2015

@davvd give us more time here pls

@davvd
Copy link
Author

davvd commented Jun 9, 2015

@davvd give us more time here pls

@yegor256 of course, thanks for letting me know, take your time

adamsiemion added a commit to adamsiemion/takes that referenced this issue Jun 9, 2015
adamsiemion added a commit to adamsiemion/takes that referenced this issue Jun 10, 2015
…etchToken -> identity; method token -> fetch
@adamsiemion
Copy link
Contributor

@davvd the changes have been delivered in PR #311, code has been merged, please close this ticket

@davvd davvd closed this as completed Jun 13, 2015
@davvd
Copy link
Author

davvd commented Jun 13, 2015

@yegor256 Thanks, closed

@davvd
Copy link
Author

davvd commented Jun 13, 2015

@ypshenychka please, review this task for compliance with our quality rules

@ypshenychka
Copy link

@adko-pl
According to our QA Rules:

Some of ticket messages must mention all pull requests where the problem was actually fixed.

Please indicate in any of your messages link to corresponding PR.

@adamsiemion
Copy link
Contributor

@ypshenychka I fixed the QA issues in this ticket

@ypshenychka
Copy link

@adko-pl Thanks!

@ypshenychka
Copy link

@davvd Quality is acceptable.

@davvd
Copy link
Author

davvd commented Jun 16, 2015

@davvd Quality is acceptable.

@ypshenychka thanks for the QA review, we'll work better next time

@davvd
Copy link
Author

davvd commented Jun 16, 2015

@adko-pl just added 10 mins to @ypshenychka (for QA), payment ID is 59387582. Thank you, I have added 30 mins to your account in payment/transaction "AP-6Y065313U9637230D", time consumed: 604 hours and 34 mins. +30 added to your rating, at the moment it is: -150

@davvd davvd mentioned this issue Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants