Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BkBasic and BkParallel are not tested #220

Closed
marcuss opened this issue Apr 29, 2015 · 16 comments
Closed

BkBasic and BkParallel are not tested #220

marcuss opened this issue Apr 29, 2015 · 16 comments

Comments

@marcuss
Copy link

marcuss commented Apr 29, 2015

BkBasic and BkParallel are not tested, even when they have 100+ lines of code.
and that BkBasic is used in the BkTimeable Test

@marcuss marcuss changed the title BkBasic and BkBasic are not tested BkBasic and BkParallel are not tested Apr 29, 2015
@yegor256 yegor256 added the bug label Apr 29, 2015
@davvd
Copy link

davvd commented Apr 29, 2015

@M4Solutions I am aware of the task, give me some time to find a developer...

@davvd
Copy link

davvd commented Apr 29, 2015

@M4Solutions there is no milestone yet, so I set it to 1.0

@davvd davvd added this to the 1.0 milestone Apr 29, 2015
@davvd
Copy link

davvd commented Apr 29, 2015

@M4Solutions thanks for tis bug, I topped your account for 15 mins, transaction 56368001

@davvd
Copy link

davvd commented Apr 29, 2015

@dmzaytsev it's yours, please go ahead

dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 29, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 29, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 30, 2015
dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Apr 30, 2015
@dmzaytsev
Copy link
Contributor

@M4Solutions the PR #223 has been merged. Could you close the task please ?

@marcuss
Copy link
Author

marcuss commented Apr 30, 2015

@dmzaytsev thank you.

@dmzaytsev
Copy link
Contributor

@M4Solutions you should close the issue
type a comment e.g. @dmzaytsev thank you :)
and click the button "close and comment"

@dmzaytsev
Copy link
Contributor

@M4Solutions According to our quality rules:

Messages in a ticket always start with a name of a user they are addressed to.

please fix your message, thank you

@marcuss
Copy link
Author

marcuss commented Apr 30, 2015

@dmzaytsev thank you

@marcuss marcuss closed this as completed Apr 30, 2015
@davvd
Copy link

davvd commented Apr 30, 2015

@M4Solutions the code made here contains a puzzle 220-30ba5607/#227, which will be resolved soon

@davvd
Copy link

davvd commented May 1, 2015

@elenavolokhova please, review this task for compliance with our quality rules

@elenavolokhova
Copy link

@davvd Quality is good here!

@davvd
Copy link

davvd commented May 4, 2015

@davvd Quality is good here!

@elenavolokhova thanks a lot

@davvd
Copy link

davvd commented May 6, 2015

@davvd Quality is good here!

@elenavolokhova thanks for the review and a good remark

@davvd
Copy link

davvd commented May 9, 2015

@dmzaytsev I added 10 mins to @elenavolokhova (for QA review) in transaction 56875162. Thanks for your contribution, 45 mins was added to your account, payment ID is 56875171, 31 hours and 48 mins spent total. the bonus for fast delivery (m=1908). +45 added to your rating, at the moment it is: +1295

@davvd
Copy link

davvd commented Jun 13, 2015

@marcuss last puzzled solved 220-30ba5607/#227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants