-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP #17 Rultor Simulator #19
Open
tannakartikey
wants to merge
1
commit into
yegor256:master
Choose a base branch
from
tannakartikey:17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yegor256 please, pay attention to this pull request |
Job |
@tannakartikey what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yegor256 I have created PR so that you can evaluate if I am going on the right track or not. Also, I have some questions.
First I will explain what I am doing:
Whenever @rultor is mentioned in the talk it starts a new daemon with variables like
head
,head_branch
,author
etc. Then firstrun.sh
is executed followed by_head.sh
. Which later starts the docker container.According to my implementation,
Rultor::Deploy#run
, the.rultor.yml
file will be read and loaded. Then directly the docker container will start. Things like setting the git config, cloning the repo(if required) will be done using customized entry.sh which is extracted from _head.shIs it the right way to do it? Or we can do it better?
I have the following question:
One option to give Rultor access to code is to mount the current directory(assuming it is being run from the project's home directory). How to access the private assets repository?
Is it a good idea to mount current directory in docker container?