Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests to JUnit 5 #939

Closed
krzyk opened this issue Nov 13, 2018 · 18 comments
Closed

Upgrade tests to JUnit 5 #939

krzyk opened this issue Nov 13, 2018 · 18 comments

Comments

@krzyk
Copy link
Collaborator

krzyk commented Nov 13, 2018

Tests should be upgrade JUnit 4.x -> JUnit 5.
All old constructs should be replaced with new ones (e.g. ExpectedException should become assertThrows).
And remove DefaultPackage PMD rule, as all the JUnit 5 test methods should have default scope, and it is generally good to limit scopes.

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 13, 2018

@0crat in

@0crat 0crat added the scope label Nov 13, 2018
@0crat
Copy link
Collaborator

0crat commented Nov 13, 2018

@0crat in (here)

@krzyk Job #939 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Nov 13, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Nov 13, 2018

@krzyk/z everybody who has role DEV is banned at #939; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Nov 18, 2018

@krzyk/z everybody who has role DEV is banned at #939; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Nov 23, 2018

@krzyk/z everybody who has role DEV is banned at #939; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2018

@krzyk/z everybody who has role DEV is banned at #939; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2019

The job #939 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 27, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 28, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 28, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 29, 2019
paulodamaso added a commit to paulodamaso/qulice that referenced this issue Jan 29, 2019
@0pdd
Copy link
Collaborator

0pdd commented Jan 30, 2019

@krzyk the puzzle #1019 is still not solved.

@paulodamaso
Copy link
Contributor

@krzyk Merged, please close

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 30, 2019

@paulodamaso thanks

@krzyk krzyk closed this as completed Jan 30, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 30, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

The job #939 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Feb 8, 2019

@krzyk the puzzle #1030 is still not solved; solved: #1019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants