Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parser.java #442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Parser.java #442

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2017

Replaced method locks with immutability. Removed redundant operations. Used buffered output for write since there was no need to check input char by char. Wrapped checked exceptions in runtime to avoid forced pollution of calling code.

Parser.java Outdated
}

private String getContentInternal(boolean unicode) {
loadFile();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side effects :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant