Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Parser #426

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor Parser #426

wants to merge 4 commits into from

Conversation

rexim
Copy link

@rexim rexim commented Aug 24, 2016

There are still lots of issues with the class parser, but I already messing with it more then 15 minutes.

Here are my remaining concerns for now:

  • All of the parser operations perform IO just by one byte/char. It would be better to process data by chunks. And the Java IO API allows that in most of the cases.
  • I don't like how getContent and getContentWithoutUnicode just cast bytes to chars without concern of the encoding!
  • I believe data < 0x80 is not the right way to filter out unicode symbols.

rexim added 4 commits August 24, 2016 23:09
@rexim
Separate method with newlines
e7d7c21 
When they are glued together they are simply undreadable
@rexim
Provide file only via constructor
3959f97 
And remove the setter/getter. That makes the object practically
immutable, which simplifies thread-safety.
@rexim
Autoclose acquired resource via try-with-resources
c9e62f7
@rexim
Collect content with StringBuilder
429e295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rexim