Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment contains "#unknown are still not solved" #234

Closed
php-coder opened this issue Jul 16, 2018 · 27 comments
Closed

Comment contains "#unknown are still not solved" #234

php-coder opened this issue Jul 16, 2018 · 27 comments
Labels

Comments

@php-coder
Copy link

php-coder commented Jul 16, 2018

When 0pdd adds a comment to a parent issue about number of not solved puzzles, the comment may contain #unknown are still not solved that is, as I suspect, a bug.

Example:

19 puzzles #839, #841, #842, #846, #847, #849, #851, #852, #853, #854, #855, #856, #859, #861, #863, #865, #866, #867, #unknown are still not solved; solved: #833, #834, #835, #836, #838, #840, #843, #844, #848, #860, #864.

Seen there: php-coder/mystamps#695 (comment)

@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

@yegor256/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jul 16, 2018

@php-coder/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@yegor256 yegor256 added the bug label Jul 17, 2018
@0crat 0crat added the scope label Jul 17, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 17, 2018

Job #234 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jul 17, 2018

Thanks for your contribution, @php-coder/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Sep 18, 2018

The job #234 assigned to @snugghash/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@snugghash
Copy link
Contributor

snugghash commented Sep 20, 2018

The issue seems to be that there's no testing done for this sort of runtime behaviour in test/test_diff.rb: test_notification_on_one_solved_update doesn't catch it.

Is this even testable? The bug seems to be that the correct link is formed, but the text is bad.

"Unknown" issues sesm to be only referenced in puzzles.rb, line 71

On paper, it seems like we can write a test_notrification_on_many_solved_including_parent to narrow this down.

@php-coder Does this unknown thing happen with every such multiple puzzles comment? Does it happen on every comment only for the links which are supposed to be to the parent issue? The example you cited has this scenario.

@0crat
Copy link
Collaborator

0crat commented Sep 23, 2018

@snugghash/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

snugghash added a commit to snugghash/0pdd that referenced this issue Sep 26, 2018
@snugghash
Copy link
Contributor

@php-coder Please review and close.

@0crat
Copy link
Collaborator

0crat commented Sep 28, 2018

The user @snugghash/z resigned from #234, please stop working. Reason for job resignation: It is older than 10 days, see §8

@0crat
Copy link
Collaborator

0crat commented Sep 28, 2018

Resigned on delay, see §8: -30 point(s) just awarded to @snugghash/z

@snugghash
Copy link
Contributor

@yegor256 ARC, please assign me back to the issue so I can put this in wait mode.

@php-coder
Copy link
Author

@php-coder Please review and close.

@snugghash Don't wait for me. I test it only when it will be in published (merged and deployed). Also, in order to test it, I should close one of my tasks, probably, that also takes time (and I'm not sure that I'll find it).

@snugghash
Copy link
Contributor

@php-coder I understand, in the end there are a lot of dependencies. For that specific PR, I'd still be be waiting on a (manually assigned?) review from REV role-person. Is that acceptable?

@ypshenychka
Copy link

@yegor256 Please assign this issue back to @snugghash. Thanks.

@yegor256
Copy link
Owner

yegor256 commented Nov 4, 2018

@0crat assign @snugghash

@0crat
Copy link
Collaborator

0crat commented Nov 4, 2018

@0crat assign @snugghash (here)

@yegor256 The job #234 assigned to @snugghash/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; we should be aware that @snugghash/z is on vacation; this ticket may be delayed; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 4, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

@0crat
Copy link
Collaborator

0crat commented Nov 14, 2018

The user @snugghash/z resigned from #234, please stop working. Reason for job resignation: It is older than 10 days, see §8

@0crat
Copy link
Collaborator

0crat commented Nov 14, 2018

Resigned on delay, see §8: -30 point(s) just awarded to @snugghash/z

@php-coder
Copy link
Author

It seems like the issue is fixed now: php-coder/mystamps#671 (comment)

Thanks!

@0crat 0crat removed the scope label Dec 2, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

Job gh:yegor256/0pdd#234 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Dec 2, 2018

The job #234 is now out of scope

@php-coder
Copy link
Author

Still here: php-coder/mystamps#695 (comment)

@php-coder php-coder reopened this Dec 17, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 17, 2018

@yegor256/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 17, 2018

@php-coder/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

snugghash added a commit to snugghash/0pdd that referenced this issue Dec 23, 2018
@yegor256
Copy link
Owner

@php-coder please, open a new ticket. Thanks!

@0pdd
Copy link
Collaborator

0pdd commented Oct 6, 2022

@php-coder the puzzle #386 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants