Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omnicompl may no completeItems yet #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions autoload/lsp/completion.vim
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@ def g:LspOmniFunc(findstart: number, base: string): any
endif

if findstart

var [triggerKind, triggerChar] = GetTriggerAttributes(lspserver)
if triggerKind < 0
return -1
Expand Down Expand Up @@ -506,7 +505,7 @@ def g:LspOmniFunc(findstart: number, base: string): any
count += 1
endwhile

if lspserver.omniCompletePending
if lspserver.omniCompletePending || !lspserver->has_key('completeItems')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lspserver.completeItems field is set to an empty List in line 488 above, when the omni-completion function
is called with findstart' set to true. Under what conditions, the completeItemskey will not be present inlspserver`?

return v:none
endif

Expand Down