fix tests with GDAL 3.7.2 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these test warnings:
```
WARNING: Method definition (::Type{Main.TestEnum})(Integer) in module Main at Enums.jl:210 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition namemap(Type{Main.TestEnum}) in module Main at Enums.jl:214 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition typemin(Type{Main.TestEnum}) in module Main at Enums.jl:215 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition typemax(Type{Main.TestEnum}) in module Main at Enums.jl:216 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition _enum_hash(Main.TestEnum, UInt64) in module Main at Enums.jl:222 overwritten on the same line (check for duplicate calls to `include`).
WARNING: Method definition instances(Type{Main.TestEnum}) in module Main at Enums.jl:225 overwritten on the same line (check for duplicate calls to `include`).
```
GDAL 3.7.2 says it's not supported with a spatial index:
```
GDALError (CE_Failure, code 1):
ICreateFeature: NULL geometry not supported with spatial index
Stacktrace:
[1] maybe_throw
@ ArchGDAL C:\Users\visser_mn\.julia\dev\GDAL\src\error.jl:42 [inlined]
[2] aftercare
@ ArchGDAL C:\Users\visser_mn\.julia\dev\GDAL\src\error.jl:59 [inlined]
[3] ogr_l_createfeature
@ ArchGDAL C:\Users\visser_mn\.julia\dev\GDAL\src\libgdal.jl:28286 [inlined]
```
Ref #158, this is probably due to GEOS 3.12
|
This actually works both before and after JuliaGeo/GDAL.jl#161. Should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with GDAL 3.7.2. Nothing major, see individual commit messages for details. This will only pass after JuliaGeo/GDAL.jl#161 is merged.