GeoPackage test no longer errors #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is all that is required to fix tests after JuliaGeo/GDAL.jl#153
yeesian
approved these changes
Jun 7, 2023
|
Maybe support for writing fields of type real has been added to the GPKG driver and gdal knows which settings to set correctly, and we're not setting it in the custom write or so? Edit: Actually the GPKG driver drives me crazy. |
maxfreu
pushed a commit
to maxfreu/ArchGDAL.jl
that referenced
this pull request
Jun 13, 2023
|
Closing in favor of #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all that is required to fix tests after JuliaGeo/GDAL.jl#153
Don't really understand, but it now only errors on
use_gdal_copy = false, whereas the default, true, does not fail.