fix: withdraw with permit using ledger with metamask #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
xgambitox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix invalid signature issue on withdraw from vault with permit when using a ledger hw wallet
Related Issue
MetaMask/eth-ledger-bridge-keyring#152
MetaMask/eth-ledger-bridge-keyring#151
MetaMask/metamask-extension#10240
Motivation and Context
Users should be able to use Metamask + Ledger to withdraw from vaults using permit. Currently the generated signature is invalid due to incorrect V parameter of https://eips.ethereum.org/EIPS/eip-712. We will temporarily reconstruct the signature using Ethers utils with correct V parameter until issue is solved.
How Has This Been Tested?
Tested with a Metamask + Ledger wallet