Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make code analyzer happy #12860

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

zverevgeny
Copy link
Collaborator

Changelog entry

rewrite a bit to pacify code analyzer on false positive issue

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@zverevgeny zverevgeny requested a review from a team as a code owner December 22, 2024 06:40
Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 06:44:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 687a9ae has started.
2024-12-22 06:44:27 UTC Artifacts will be uploaded here
2024-12-22 06:47:27 UTC ya make is running...
🟡 2024-12-22 07:36:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19052 17521 0 2 1416 113

2024-12-22 07:38:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-22 07:49:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 49 0 1 0 110

2024-12-22 07:49:47 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-22 08:01:28 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
155 (only retried tests) 45 0 1 0 109

🟢 2024-12-22 08:01:35 UTC Build successful.
🟢 2024-12-22 08:01:55 UTC ydbd size 2.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: 687a9ae diff diff %
ydbd size 2 235 522 680 Bytes 2 235 522 632 Bytes -48 Bytes -0.000%
ydbd stripped size 477 900 048 Bytes 477 899 984 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 06:44:27 UTC Pre-commit check linux-x86_64-release-asan for 687a9ae has started.
2024-12-22 06:44:38 UTC Artifacts will be uploaded here
2024-12-22 06:47:32 UTC ya make is running...
🟡 2024-12-22 07:49:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12078 12001 0 23 10 44

🟢 2024-12-22 07:50:37 UTC Build successful.
🟢 2024-12-22 07:51:02 UTC ydbd size 3.6 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: 687a9ae diff diff %
ydbd size 3 866 166 992 Bytes 3 866 166 912 Bytes -80 Bytes -0.000%
ydbd stripped size 1 350 424 112 Bytes 1 350 424 048 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Dec 22, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 22, 2024
Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 15:20:41 UTC Pre-commit check linux-x86_64-release-asan for 9b76df4 has started.
2024-12-22 15:21:14 UTC Artifacts will be uploaded here
2024-12-22 15:24:05 UTC ya make is running...
🟡 2024-12-22 16:24:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12078 12002 0 26 6 44

🟢 2024-12-22 16:26:17 UTC Build successful.
🟢 2024-12-22 16:26:41 UTC ydbd size 3.6 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: 9b76df4 diff diff %
ydbd size 3 866 166 992 Bytes 3 866 166 912 Bytes -80 Bytes -0.000%
ydbd stripped size 1 350 424 112 Bytes 1 350 424 048 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 15:20:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9b76df4 has started.
2024-12-22 15:20:46 UTC Artifacts will be uploaded here
2024-12-22 15:23:34 UTC ya make is running...
🟡 2024-12-22 16:16:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19049 17510 0 5 1416 118

2024-12-22 16:18:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-22 16:29:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 62 0 0 0 110

🟢 2024-12-22 16:29:53 UTC Build successful.
🟢 2024-12-22 16:30:09 UTC ydbd size 2.1 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 12789bd merge: 9b76df4 diff diff %
ydbd size 2 235 522 680 Bytes 2 235 522 632 Bytes -48 Bytes -0.000%
ydbd stripped size 477 900 048 Bytes 477 899 984 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit 1c38970 into ydb-platform:main Dec 25, 2024
14 of 15 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 4, 2025
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants