Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Isolation: kqp #12825

Merged
merged 24 commits into from
Dec 24, 2024
Merged

Snapshot Isolation: kqp #12825

merged 24 commits into from
Dec 24, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Dec 20, 2024

Changelog entry

Snapshot Isolation

Changelog category

  • New feature

Additional information

...

@nikvas0 nikvas0 requested a review from a team as a code owner December 20, 2024 11:07
@nikvas0 nikvas0 changed the title Snapshot Isolation Snapshot Isolation: kqp Dec 20, 2024
@nikvas0 nikvas0 changed the title Snapshot Isolation: kqp [WIP] Snapshot Isolation: kqp Dec 20, 2024
@nikvas0 nikvas0 closed this Dec 22, 2024
@nikvas0 nikvas0 reopened this Dec 22, 2024
Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 19:34:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for d1f40a6 has started.
2024-12-22 19:34:49 UTC Artifacts will be uploaded here
2024-12-22 19:38:17 UTC ya make is running...
🟡 2024-12-22 21:13:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31569 28580 0 40 2831 118

2024-12-22 21:15:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-22 21:31:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 79 0 37 1 113

2024-12-22 21:31:55 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-22 21:43:38 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 69 0 37 0 110

🟢 2024-12-22 21:43:45 UTC Build successful.
🟢 2024-12-22 21:44:09 UTC ydbd size 2.1 GiB changed* by +51.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 12789bd merge: d1f40a6 diff diff %
ydbd size 2 235 522 680 Bytes 2 235 575 640 Bytes +51.7 KiB +0.002%
ydbd stripped size 477 900 048 Bytes 477 912 880 Bytes +12.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 19:34:37 UTC Pre-commit check linux-x86_64-release-asan for d1f40a6 has started.
2024-12-22 19:34:48 UTC Artifacts will be uploaded here
2024-12-22 19:38:07 UTC ya make is running...
🟡 2024-12-22 21:15:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14538 14408 0 72 11 47

🟢 2024-12-22 21:17:06 UTC Build successful.
🟡 2024-12-22 21:17:32 UTC ydbd size 3.6 GiB changed* by +102.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 12789bd merge: d1f40a6 diff diff %
ydbd size 3 866 166 992 Bytes 3 866 272 392 Bytes +102.9 KiB +0.003%
ydbd stripped size 1 350 424 112 Bytes 1 350 461 360 Bytes +36.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 22:14:18 UTC Pre-commit check linux-x86_64-release-asan for b09db57 has started.
2024-12-22 22:14:40 UTC Artifacts will be uploaded here
2024-12-22 22:18:07 UTC ya make is running...
🟡 2024-12-22 23:24:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14538 14426 0 55 9 48

🟢 2024-12-22 23:25:36 UTC Build successful.
🟡 2024-12-22 23:26:00 UTC ydbd size 3.6 GiB changed* by +103.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 12789bd merge: b09db57 diff diff %
ydbd size 3 866 166 992 Bytes 3 866 273 232 Bytes +103.8 KiB +0.003%
ydbd stripped size 1 350 424 112 Bytes 1 350 461 424 Bytes +36.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 22, 2024

2024-12-22 22:16:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for b09db57 has started.
2024-12-22 22:16:40 UTC Artifacts will be uploaded here
2024-12-22 22:20:00 UTC ya make is running...
🟡 2024-12-22 23:20:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31569 28589 0 36 2831 113

2024-12-22 23:22:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-22 23:34:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 67 0 34 1 110

2024-12-22 23:34:29 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-22 23:46:27 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 63 0 31 0 110

🟢 2024-12-22 23:46:33 UTC Build successful.
🟢 2024-12-22 23:46:54 UTC ydbd size 2.1 GiB changed* by +51.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 12789bd merge: b09db57 diff diff %
ydbd size 2 235 522 680 Bytes 2 235 574 856 Bytes +51.0 KiB +0.002%
ydbd stripped size 477 900 048 Bytes 477 912 688 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

adameat
adameat previously approved these changes Dec 23, 2024
Copy link
Member

@adameat adameat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto changes seem okay to me

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 11:45:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 052afff has started.
2024-12-23 11:45:14 UTC Artifacts will be uploaded here
2024-12-23 11:48:34 UTC ya make is running...
🟢 2024-12-23 13:12:04 UTC ydbd size 2.1 GiB changed* by +50.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1e172ec merge: 052afff diff diff %
ydbd size 2 234 949 880 Bytes 2 235 001 768 Bytes +50.7 KiB +0.002%
ydbd stripped size 477 965 520 Bytes 477 978 096 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-23 13:12:05 UTC Check cancelled

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 11:45:20 UTC Pre-commit check linux-x86_64-release-asan for 052afff has started.
2024-12-23 11:45:32 UTC Artifacts will be uploaded here
2024-12-23 11:49:00 UTC ya make is running...
2024-12-23 13:11:57 UTC Check cancelled

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto changes lgtm

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:13:39 UTC Pre-commit check linux-x86_64-release-asan for f147c0d has started.
2024-12-23 13:13:51 UTC Artifacts will be uploaded here
2024-12-23 13:17:26 UTC ya make is running...
2024-12-23 13:33:10 UTC Check cancelled

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:15:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for f147c0d has started.
2024-12-23 13:15:43 UTC Artifacts will be uploaded here
2024-12-23 13:19:43 UTC ya make is running...
2024-12-23 13:33:08 UTC Check cancelled

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:34:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for af0f3e7 has started.
2024-12-23 13:35:10 UTC Artifacts will be uploaded here
2024-12-23 13:38:49 UTC ya make is running...
🟡 2024-12-23 15:07:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31522 28561 0 9 2831 121

2024-12-23 15:10:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-23 15:22:22 UTC ydbd size 2.1 GiB changed* by +55.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1e172ec merge: af0f3e7 diff diff %
ydbd size 2 234 949 880 Bytes 2 235 006 200 Bytes +55.0 KiB +0.003%
ydbd stripped size 477 965 520 Bytes 477 978 320 Bytes +12.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-23 15:22:24 UTC Check cancelled

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 13:34:43 UTC Pre-commit check linux-x86_64-release-asan for af0f3e7 has started.
2024-12-23 13:36:36 UTC Artifacts will be uploaded here
2024-12-23 13:40:46 UTC ya make is running...
🟡 2024-12-23 15:18:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14542 14456 0 20 15 51

🟢 2024-12-23 15:19:25 UTC Build successful.
🟡 2024-12-23 15:19:49 UTC ydbd size 3.6 GiB changed* by +115.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1e172ec merge: af0f3e7 diff diff %
ydbd size 3 865 485 568 Bytes 3 865 604 064 Bytes +115.7 KiB +0.003%
ydbd stripped size 1 350 611 152 Bytes 1 350 656 880 Bytes +44.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 15:24:46 UTC Pre-commit check linux-x86_64-release-asan for 2b91540 has started.
2024-12-23 15:24:52 UTC Artifacts will be uploaded here
2024-12-23 15:28:18 UTC ya make is running...
🟡 2024-12-23 17:09:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14542 14453 0 24 9 56

🟢 2024-12-23 17:10:40 UTC Build successful.
🟡 2024-12-23 17:11:05 UTC ydbd size 3.6 GiB changed* by +101.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 24c2d11 merge: 2b91540 diff diff %
ydbd size 3 865 485 696 Bytes 3 865 589 888 Bytes +101.8 KiB +0.003%
ydbd stripped size 1 350 611 280 Bytes 1 350 653 360 Bytes +41.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 23, 2024

2024-12-23 15:26:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b91540 has started.
2024-12-23 15:26:44 UTC Artifacts will be uploaded here
2024-12-23 15:30:04 UTC ya make is running...
🟡 2024-12-23 17:00:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31522 28563 0 4 2831 124

2024-12-23 17:03:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-23 17:15:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 69 0 0 1 118

🟢 2024-12-23 17:16:06 UTC Build successful.
🟢 2024-12-23 17:26:02 UTC ydbd size 2.1 GiB changed* by +48.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 24c2d11 merge: 2b91540 diff diff %
ydbd size 2 234 950 056 Bytes 2 234 999 608 Bytes +48.4 KiB +0.002%
ydbd stripped size 477 965 648 Bytes 477 977 232 Bytes +11.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

gridnevvvit
gridnevvvit previously approved these changes Dec 23, 2024
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 10:16:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for f7eef0e has started.
2024-12-24 10:16:33 UTC Artifacts will be uploaded here
2024-12-24 10:20:17 UTC ya make is running...
🟡 2024-12-24 11:50:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31522 28561 0 7 2831 123

2024-12-24 11:52:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 12:05:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 72 0 0 0 118

🟢 2024-12-24 12:05:22 UTC Build successful.
🟠 2024-12-24 12:05:39 UTC Muted new 6 tests
🟢 2024-12-24 12:05:57 UTC ydbd size 2.1 GiB changed* by +57.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7cd35f3 merge: f7eef0e diff diff %
ydbd size 2 235 028 664 Bytes 2 235 087 488 Bytes +57.4 KiB +0.003%
ydbd stripped size 477 983 088 Bytes 477 999 056 Bytes +15.6 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 10:17:33 UTC Pre-commit check linux-x86_64-release-asan for f7eef0e has started.
2024-12-24 10:17:44 UTC Artifacts will be uploaded here
2024-12-24 10:21:06 UTC ya make is running...
🟡 2024-12-24 12:05:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14542 14436 0 37 13 56

🟢 2024-12-24 12:06:26 UTC Build successful.
🟡 2024-12-24 12:06:51 UTC ydbd size 3.6 GiB changed* by +112.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7cd35f3 merge: f7eef0e diff diff %
ydbd size 3 865 652 520 Bytes 3 865 767 784 Bytes +112.6 KiB +0.003%
ydbd stripped size 1 350 679 408 Bytes 1 350 726 352 Bytes +45.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 12:34:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5661775 has started.
2024-12-24 12:34:41 UTC Artifacts will be uploaded here
2024-12-24 12:37:59 UTC ya make is running...
🟡 2024-12-24 14:05:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31524 28557 0 10 2831 126

2024-12-24 14:09:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 14:21:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
187 (only retried tests) 70 0 0 0 117

🟢 2024-12-24 14:22:04 UTC Build successful.
🟠 2024-12-24 14:22:27 UTC Muted new 6 tests
🟢 2024-12-24 14:22:44 UTC ydbd size 2.1 GiB changed* by +65.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 596609e merge: 5661775 diff diff %
ydbd size 2 235 055 600 Bytes 2 235 123 080 Bytes +65.9 KiB +0.003%
ydbd stripped size 477 989 296 Bytes 478 009 552 Bytes +19.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 12:34:48 UTC Pre-commit check linux-x86_64-release-asan for 5661775 has started.
2024-12-24 12:35:00 UTC Artifacts will be uploaded here
2024-12-24 12:38:29 UTC ya make is running...
🟡 2024-12-24 14:23:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14544 14438 0 31 18 57

🟢 2024-12-24 14:25:14 UTC Build successful.
🟡 2024-12-24 14:25:42 UTC ydbd size 3.6 GiB changed* by +115.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 596609e merge: 5661775 diff diff %
ydbd size 3 865 725 992 Bytes 3 865 844 016 Bytes +115.3 KiB +0.003%
ydbd stripped size 1 350 701 264 Bytes 1 350 744 816 Bytes +42.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 3096657 into ydb-platform:main Dec 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants