Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change install instruction for ydb-dstool #11834

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Nov 21, 2024

Changelog entry

Change ydb-dstool from python package to bin

Changelog category

  • Documentation

Additional information

...

@kruall kruall requested a review from a team as a code owner November 21, 2024 09:55
Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 09:57:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc2140f has started.
2024-11-21 09:57:51 UTC Artifacts will be uploaded here
2024-11-21 10:00:43 UTC ya make is running...
🟢 2024-11-21 10:02:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-21 10:02:10 UTC Build successful.

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 09:59:55 UTC Pre-commit check linux-x86_64-release-asan for dc2140f has started.
2024-11-21 10:00:30 UTC Artifacts will be uploaded here
2024-11-21 10:03:35 UTC ya make is running...
🟢 2024-11-21 10:03:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-21 10:03:47 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov
Copy link
Member

blinkov commented Dec 3, 2024

Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:03:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 66c07ba has started.
2024-12-25 10:04:31 UTC Artifacts will be uploaded here
2024-12-25 10:07:34 UTC ya make is running...
🟢 2024-12-25 10:09:01 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 10:09:06 UTC Build successful.

Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:05:48 UTC Pre-commit check linux-x86_64-release-asan for 66c07ba has started.
2024-12-25 10:05:58 UTC Artifacts will be uploaded here
2024-12-25 10:08:19 UTC ya make is running...
🟢 2024-12-25 10:09:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 10:09:25 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

ydb-dstool -e <bs_endpoint> cluster list
```

* `bs_endpoint`: URI of the interface for {{ ydb-short-name }} cluster distributed storage management. The interface is accessible over HTTP on any cluster node on port 8765 by default. URI example: `http://localhost:8765`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `bs_endpoint`: URI of the interface for {{ ydb-short-name }} cluster distributed storage management. The interface is accessible over HTTP on any cluster node on port 8765 by default. URI example: `http://localhost:8765`.
* `bs_endpoint`: URI of the cluster's HTTP endpoint, the same endpoint that serves the [Embedded UI](../../embedded-ui/index.md). Example: `http://localhost:8765`.


1. Test it by running the command that shows cluster information:
```bash
curl -sSL 'https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.sh' | bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -sSL 'https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.sh' | bash
curl -sSL 'https://install.ydb.tech/dstool' | bash

```bash
ydb-dstool -e <bs_endpoint> cluster list
```
The script will install the {{ ydb-short-name }} DSTool and add the executable file path to the `PATH` environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The script will install the {{ ydb-short-name }} DSTool and add the executable file path to the `PATH` environment variable.
The script will install the {{ ydb-short-name }} DSTool. If the script is run from a `bash` or `zsh` shell, it will also add the `ydb-dstool` executable to the `PATH` environment variable. Otherwise, you can run it from the `~/ydb-dstool/bin` folder or add it to `PATH` manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it adds to PATH the path to the folder containing the executable, not the executable's path.


* `bs_endpoint`: URI of the interface for {{ ydb-short-name }} cluster distributed storage management. The interface is accessible over HTTP on any cluster node on port 8765 by default. URI example: `http://localhost:8765`.
{% note info %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% note info %}


Result:
The script will update the `PATH` variable only if you run it in the bash or zsh command shell. If you run the script in a different shell, add the path to the CLI to the `PATH` variable manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The script will update the `PATH` variable only if you run it in the bash or zsh command shell. If you run the script in a different shell, add the path to the CLI to the `PATH` variable manually.

1. Run the command:

```bash
curl -sSL 'https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.sh' | bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -sSL 'https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.sh' | bash
curl -sSL 'https://install.ydb.tech/dstool' | bash

Comment on lines 41 to 47
The script will install the {{ ydb-short-name }} DSTool and add the executable file path to the `PATH` environment variable.

1. To update the environment variables, restart the command shell.

1. Test it by running the command that shows cluster information:

{% include [test step](./_includes/test.md) %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste: move this to an include file.

- in **PowerShell**:

```powershell
iex (New-Object System.Net.WebClient).DownloadString('https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.ps1')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
iex (New-Object System.Net.WebClient).DownloadString('https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.ps1')
iex (New-Object System.Net.WebClient).DownloadString('https://install.ydb.tech/dstool-windows')

- in **CMD**:

```cmd
@"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -Command "iex ((New-Object System.Net.WebClient).DownloadString('https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.ps1'))"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -Command "iex ((New-Object System.Net.WebClient).DownloadString('https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.ps1'))"
@"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -Command "iex ((New-Object System.Net.WebClient).DownloadString('https://install.ydb.tech/dstool-windows'))"

@"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -Command "iex ((New-Object System.Net.WebClient).DownloadString('https://storage.yandexcloud.net/yandexcloud-ydb-dstool/install.ps1'))"
```

1. Specify whether to add the executable file path to the `PATH` environment variable:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Specify whether to add the executable file path to the `PATH` environment variable:
1. Specify whether to add `ydb-dstool` to the `PATH` environment variable:

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:34:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c94d7b has started.
2025-01-10 15:34:28 UTC Artifacts will be uploaded here
2025-01-10 15:36:47 UTC ya make is running...
🟢 2025-01-10 15:38:10 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 15:38:15 UTC Build successful.

Copy link

❌ Documentation build

Revision build failed

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:35:31 UTC Pre-commit check linux-x86_64-release-asan for 3c94d7b has started.
2025-01-10 15:35:44 UTC Artifacts will be uploaded here
2025-01-10 15:38:07 UTC ya make is running...
🟢 2025-01-10 15:38:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 15:38:18 UTC Build successful.

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:47:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3235567 has started.
2025-01-10 15:48:07 UTC Artifacts will be uploaded here
2025-01-10 15:50:44 UTC ya make is running...
🔴 2025-01-10 15:52:19 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 15:48:02 UTC Pre-commit check linux-x86_64-release-asan for 3235567 has started.
2025-01-10 15:48:15 UTC Artifacts will be uploaded here
2025-01-10 15:50:42 UTC ya make is running...
🔴 2025-01-10 15:52:04 UTC Build failed, see the logs. Also see fail summary

Copy link

❌ Documentation build

Revision build failed

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 16:00:56 UTC Pre-commit check linux-x86_64-release-asan for 53408c5 has started.
2025-01-10 16:01:31 UTC Artifacts will be uploaded here
2025-01-10 16:04:33 UTC ya make is running...
🟢 2025-01-10 16:06:07 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 16:06:13 UTC Build successful.

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 16:03:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53408c5 has started.
2025-01-10 16:03:31 UTC Artifacts will be uploaded here
2025-01-10 16:05:52 UTC ya make is running...
🟢 2025-01-10 16:06:52 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 16:06:58 UTC Build successful.

Copy link

❌ Documentation build

Revision build failed

1 similar comment
Copy link

❌ Documentation build

Revision build failed

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 17:28:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 80d6b33 has started.
2025-01-10 17:28:45 UTC Artifacts will be uploaded here
2025-01-10 17:31:17 UTC ya make is running...
🟢 2025-01-10 17:32:55 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 17:33:00 UTC Build successful.

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 17:28:43 UTC Pre-commit check linux-x86_64-release-asan for 80d6b33 has started.
2025-01-10 17:29:08 UTC Artifacts will be uploaded here
2025-01-10 17:31:38 UTC ya make is running...
🟢 2025-01-10 17:33:12 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 17:33:18 UTC Build successful.

Copy link

❌ Documentation build

Revision build failed

@kruall kruall added the rebase-and-check Rebase PR with the current base branch and check label Jan 13, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 10:21:09 UTC Pre-commit check linux-x86_64-release-asan for 0a3c2ab has started.
2025-01-13 10:21:22 UTC Artifacts will be uploaded here
2025-01-13 10:23:47 UTC ya make is running...
🟢 2025-01-13 10:25:23 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 10:25:30 UTC Build successful.

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 10:21:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a3c2ab has started.
2025-01-13 10:21:31 UTC Artifacts will be uploaded here
2025-01-13 10:23:56 UTC ya make is running...
🟢 2025-01-13 10:25:23 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 10:25:28 UTC Build successful.

Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (6)

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 7: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "curl -sSL 'https://install.ydb..."]

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 7: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "curl -sSL 'https://install.ydb..."]

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:02:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1f9c04d has started.
2025-01-13 11:02:32 UTC Artifacts will be uploaded here
2025-01-13 11:05:02 UTC ya make is running...
2025-01-13 11:05:50 UTC Check cancelled

Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (6)

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 7: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "curl -sSL 'https://install.ydb..."]

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 7: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "curl -sSL 'https://install.ydb..."]

@kruall kruall force-pushed the dstool/change_install_docs branch from ce6e020 to a57d13a Compare January 13, 2025 11:05
Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (4)

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /en/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 13: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

❌ /ru/reference/ydb-dstool/_includes/unix_install.md: 5: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:12:01 UTC Pre-commit check linux-x86_64-release-asan for b7d3f82 has started.
2025-01-13 11:12:13 UTC Artifacts will be uploaded here
2025-01-13 11:14:36 UTC ya make is running...
2025-01-13 11:15:08 UTC Check cancelled

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:14:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for b7d3f82 has started.
2025-01-13 11:14:33 UTC Artifacts will be uploaded here
2025-01-13 11:15:06 UTC Check cancelled

@kruall kruall force-pushed the dstool/change_install_docs branch from a57d13a to 2890f2e Compare January 13, 2025 11:14
Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:18:07 UTC Pre-commit check linux-x86_64-release-asan for dde3ef1 has started.
2025-01-13 11:18:18 UTC Artifacts will be uploaded here
2025-01-13 11:20:38 UTC ya make is running...
🟢 2025-01-13 11:22:01 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 11:22:07 UTC Build successful.

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:18:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for dde3ef1 has started.
2025-01-13 11:18:41 UTC Artifacts will be uploaded here
2025-01-13 11:21:06 UTC ya make is running...
🟢 2025-01-13 11:22:34 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 11:22:40 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@kruall kruall force-pushed the dstool/change_install_docs branch from 2890f2e to 3ec4e78 Compare January 13, 2025 11:24
Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:27:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5de52c2 has started.
2025-01-13 11:28:10 UTC Artifacts will be uploaded here
2025-01-13 11:30:33 UTC ya make is running...
🟢 2025-01-13 11:31:59 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 11:32:05 UTC Build successful.

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 11:28:17 UTC Pre-commit check linux-x86_64-release-asan for 5de52c2 has started.
2025-01-13 11:28:28 UTC Artifacts will be uploaded here
2025-01-13 11:30:49 UTC ya make is running...
🟢 2025-01-13 11:32:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 11:32:18 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 12:06:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for b0e7270 has started.
2025-01-13 12:07:03 UTC Artifacts will be uploaded here
2025-01-13 12:09:52 UTC ya make is running...
🟢 2025-01-13 12:11:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 12:11:25 UTC Build successful.

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 12:08:42 UTC Pre-commit check linux-x86_64-release-asan for b0e7270 has started.
2025-01-13 12:09:02 UTC Artifacts will be uploaded here
2025-01-13 12:11:36 UTC ya make is running...
🟢 2025-01-13 12:11:42 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 12:11:49 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed not-for-changelog labels Jan 14, 2025
@blinkov blinkov enabled auto-merge (squash) January 14, 2025 05:17
curl -sSL 'https://install.ydb.tech/dstool' | bash
```

The script will install the {{ ydb-short-name }} DSTool. If the script is run from a `bash` or `zsh` shell, it will also add the `ydb-dstool` executable to the `PATH` environment variable. Otherwise, you can run it from the `~/ydb-dstool/bin` folder or add it to `PATH` manually.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я, кстати, против ~/ydb-dstool/bin. На мой взгляд у ydb, dstool и ydbops должен быть один каталог ydb

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 08:16:40 UTC Pre-commit check linux-x86_64-release-asan for 5488aa6 has started.
2025-01-14 08:16:45 UTC Artifacts will be uploaded here
2025-01-14 08:19:16 UTC ya make is running...
🟢 2025-01-14 08:21:00 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-14 08:21:06 UTC Build successful.

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 08:18:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5488aa6 has started.
2025-01-14 08:18:47 UTC Artifacts will be uploaded here
2025-01-14 08:21:11 UTC ya make is running...
🟢 2025-01-14 08:21:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-14 08:21:23 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit 0e5d23d into ydb-platform:main Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants