Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request settings to execution options #59

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

LuckySting
Copy link
Contributor

@LuckySting LuckySting commented Oct 31, 2024

Problem

Now it is impossible to configure the execution of requests, especially timeout.

Proposal

Add a connection option ydb_request_timeout execution option, which provided to the settings of each execution. Also the trace_id propagation is added.

Usage

On engine level:

engine = sa.create_engine(...).execution_options(ydb_request_settigns=ydb.BaseRequestSettings())

On connection level:

with engine.connect(...) as conn.
    conn.execution_options(ydb_request_settigns=ydb.BaseRequestSettings())

@LuckySting LuckySting force-pushed the tracing-and-request-timeout branch 2 times, most recently from 7021cc9 to 6732a04 Compare October 31, 2024 14:38
@LuckySting LuckySting changed the title Add request settings: request_timeout and trace_id Add request settings to execution options Oct 31, 2024
@LuckySting LuckySting force-pushed the tracing-and-request-timeout branch from 6732a04 to aa6d432 Compare October 31, 2024 14:58
@LuckySting LuckySting force-pushed the tracing-and-request-timeout branch from aa6d432 to 06f35f9 Compare October 31, 2024 15:02
@vgvoleg vgvoleg merged commit 8eefc90 into ydb-platform:main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants