Async driver implementation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Feb 2, 2024
test/test_core.py
Outdated
| finally: | ||
| loop.run_until_complete(driver.stop()) | ||
|
|
||
| loop.run_until_complete(driver.stop()) |
There was a problem hiding this comment.
Do you need call driver.stop() twice?
LuckySting
force-pushed
the
make-dbapi-class
branch
from
3ca000d to
42ed795
Compare
LuckySting
force-pushed
the
make-dbapi-class
branch
from
42ed795 to
67814a9
Compare
rekby
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Add isort
isort is a Python utility / library to sort imports alphabetically, and automatically separated into sections and by type. It will help to keep imports well organized in project during the development.
Implement asynchronous driver
The support of an async drivers is needed to allow usage of this dialect in async context, which is the modern way to write applications in python. I used SQLAlchemy async-sync-async trick to implement an async driver without the copy-paste of code.
Enable multi-driver testing
The SQLAlchemy test suite supports running its test on a several combinations of dialects, which I use to run the same test on both sync and async drivers.