Skip to content

Commit

Permalink
omg it works
Browse files Browse the repository at this point in the history
  • Loading branch information
vgvoleg committed Nov 2, 2024
1 parent db7ee95 commit 97c02ed
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
sqlalchemy >= 2.0.7, < 3.0.0
ydb >= 3.18.7
# ydb-dbapi==0.0.1b6
ydb >= 3.18.8
ydb-dbapi==0.0.1b7
/Users/ovcharuk/work/ydb-sqlalchemy/ydb_dbapi-0.0.1b6-py3-none-any.whl
5 changes: 2 additions & 3 deletions test-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
pyyaml==5.3.1
greenlet
sqlalchemy==2.0.7
ydb >= 3.18.7
# ydb-dbapi==0.0.1b6
/Users/ovcharuk/work/ydb-sqlalchemy/ydb_dbapi-0.0.1b6-py3-none-any.whl
ydb >= 3.18.8
ydb-dbapi==0.0.1b7
requests<2.29
pytest==7.2.2
docker==6.0.1
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ ignore_errors = True
commands =
docker-compose up -d
python {toxinidir}/wait_container_ready.py
; pytest -v test --dbdriver ydb --dbdriver ydb_async
pytest -v test/test_suite.py::FetchLimitOffsetTest::test_simple_offset --dbdriver ydb --dbdriver ydb_async
pytest -v test --dbdriver ydb --dbdriver ydb_async
; pytest -v test/test_suite.py::FetchLimitOffsetTest::test_simple_offset --dbdriver ydb --dbdriver ydb_async
; pytest -v test/test_core.py::TestSimpleSelect::test_sa_select_simple test/test_core.py::TestText::test_sa_text test/test_suite.py::ContainerTypesTest::test_struct_type_bind_variable_text --dbdriver ydb --dbdriver ydb_async
; pytest -v test_dbapi
pytest -v ydb_sqlalchemy
Expand Down
Binary file removed ydb_dbapi-0.0.1b6-py3-none-any.whl
Binary file not shown.
2 changes: 1 addition & 1 deletion ydb_sqlalchemy/sqlalchemy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def limit_clause(self, select, **kw):
select._offset_clause, types.UInt64, skip_types=(types.UInt64, types.UInt32, types.UInt16, types.UInt8)
)
if select._limit_clause is None:
text += "\n LIMIT NULL"
text += "\n LIMIT 1000" # For some reason, YDB do not support LIMIT NULL OFFSET <num>
text += " OFFSET " + self.process(offset_clause, **kw)
return text

Expand Down

0 comments on commit 97c02ed

Please sign in to comment.