Skip to content

Commit

Permalink
style fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
vgvoleg committed Jan 31, 2025
1 parent 7c607f5 commit 4f38b65
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 16 deletions.
24 changes: 9 additions & 15 deletions ydb/_grpc/grpcwrapper/ydb_topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -976,17 +976,15 @@ def from_proto(msg: ydb_topic_pb2.PartitioningSettings) -> "PartitioningSettings
min_active_partitions=msg.min_active_partitions,
partition_count_limit=msg.partition_count_limit,
max_active_partitions=msg.max_active_partitions,
auto_partitioning_settings=AutoPartitioningSettings.from_proto(
msg.auto_partitioning_settings
),
auto_partitioning_settings=AutoPartitioningSettings.from_proto(msg.auto_partitioning_settings),
)

def to_proto(self) -> ydb_topic_pb2.PartitioningSettings:
return ydb_topic_pb2.PartitioningSettings(
min_active_partitions=self.min_active_partitions,
partition_count_limit=self.partition_count_limit,
max_active_partitions=self.max_active_partitions,
auto_partitioning_settings=self.auto_partitioning_settings.to_proto()
auto_partitioning_settings=self.auto_partitioning_settings.to_proto(),
)


Expand Down Expand Up @@ -1027,7 +1025,7 @@ class AutoPartitioningSettings(IToProto, IFromProto, IFromPublic, IToPublic):

@staticmethod
def from_public(
settings: Optional[ydb_topic_public_types.PublicAutoPartitioningSettings]
settings: Optional[ydb_topic_public_types.PublicAutoPartitioningSettings],
) -> Optional[AutoPartitioningSettings]:
if not settings:
return None
Expand All @@ -1038,22 +1036,19 @@ def from_public(
stabilization_window=settings.stabilization_window,
up_utilization_percent=settings.up_utilization_percent,
down_utilization_percent=settings.down_utilization_percent,
)
),
)

@staticmethod
def from_proto(msg: ydb_topic_pb2.AutoPartitioningSettings) -> AutoPartitioningSettings:
return AutoPartitioningSettings(
strategy=AutoPartitioningStrategy.from_proto(msg.strategy),
partition_write_speed=AutoPartitioningWriteSpeedStrategy.from_proto(
msg.partition_write_speed
),
partition_write_speed=AutoPartitioningWriteSpeedStrategy.from_proto(msg.partition_write_speed),
)

def to_proto(self) -> ydb_topic_pb2.AutoPartitioningSettings:
return ydb_topic_pb2.AutoPartitioningSettings(
strategy=self.strategy,
partition_write_speed=self.partition_write_speed.to_proto()
strategy=self.strategy, partition_write_speed=self.partition_write_speed.to_proto()
)

def to_public(self) -> ydb_topic_public_types.PublicAutoPartitioningSettings:
Expand Down Expand Up @@ -1109,7 +1104,7 @@ class AlterAutoPartitioningSettings(IToProto, IFromPublic):

@staticmethod
def from_public(
settings: Optional[ydb_topic_public_types.PublicAlterAutoPartitioningSettings]
settings: Optional[ydb_topic_public_types.PublicAlterAutoPartitioningSettings],
) -> Optional[AlterAutoPartitioningSettings]:
if not settings:
return None
Expand All @@ -1120,7 +1115,7 @@ def from_public(
stabilization_window=settings.set_stabilization_window,
up_utilization_percent=settings.set_up_utilization_percent,
down_utilization_percent=settings.set_down_utilization_percent,
)
),
)

def to_proto(self) -> ydb_topic_pb2.AlterAutoPartitioningSettings:
Expand Down Expand Up @@ -1227,7 +1222,7 @@ def from_public(req: ydb_topic_public_types.CreateTopicRequestParams):
min_active_partitions=req.min_active_partitions,
partition_count_limit=req.partition_count_limit,
max_active_partitions=req.max_active_partitions,
auto_partitioning_settings=auto_partitioning_settings
auto_partitioning_settings=auto_partitioning_settings,
),
retention_period=req.retention_period,
retention_storage_mb=req.retention_storage_mb,
Expand Down Expand Up @@ -1304,7 +1299,6 @@ def from_public(req: ydb_topic_public_types.AlterTopicRequestParams) -> AlterTop
req.alter_auto_partitioning_settings
)


drop_consumers = req.drop_consumers if req.drop_consumers else []

return AlterTopicRequest(
Expand Down
4 changes: 3 additions & 1 deletion ydb/_topic_reader/topic_reader_asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,9 @@ def _on_partition_session_stop(self, message: StreamReadMessage.StopPartitionSes
)

def _on_end_partition_session(self, message: StreamReadMessage.EndPartitionSession):
logger.info(f"End partition session with id: {message.partition_session_id}, child partitions: {message.child_partition_ids}")
logger.info(
f"End partition session with id: {message.partition_session_id}, child partitions: {message.child_partition_ids}"
)

def _on_read_response(self, message: StreamReadMessage.ReadResponse):
self._buffer_consume_bytes(message.bytes_size)
Expand Down

0 comments on commit 4f38b65

Please sign in to comment.