Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the iframe by default in a notebook setting #321

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

sbrugman
Copy link
Collaborator

@sbrugman sbrugman commented Jan 13, 2020

Use the iframe by default in a notebook setting (for backwards compatibility and temporary solution for #319)

Include repr on message class (#315).

…ibility and temporary solution for #319)

Include __repr__ on message class (#315).
@sbrugman sbrugman changed the title Use the iframe by default in a notebook setting (for backwards compat… Use the iframe by default in a notebook setting Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #321 into master will increase coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   87.81%   87.83%   +0.01%     
==========================================
  Files          84       84              
  Lines        1814     1816       +2     
==========================================
+ Hits         1593     1595       +2     
  Misses        221      221
Flag Coverage Δ
#examples 0% <0%> (ø) ⬆️
#issue 80.8% <40%> (-0.05%) ⬇️
#unit 85.21% <60%> (+0.01%) ⬆️
Impacted Files Coverage Δ
setup.py 0% <0%> (ø) ⬆️
src/pandas_profiling/__init__.py 73.17% <0%> (ø) ⬆️
src/pandas_profiling/model/messages.py 98.88% <100%> (+0.02%) ⬆️
src/pandas_profiling/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab2122...00fab4c. Read the comment docs.

@sbrugman sbrugman merged commit df8a9e8 into master Jan 14, 2020
@sbrugman sbrugman deleted the notebook_defaults branch January 14, 2020 06:13
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this pull request Oct 11, 2020
Use the iframe by default in a notebook setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant