chore(deps): remove seaborn upper limit #1570
Conversation
Signed-off-by: ggydush <[email protected]>
ggydush
changed the title
There was a problem hiding this comment.
Hi @ggydush ,
thank you for your contribution. Nevertheless, and due to past experiences where new minor releases from packages like numpy, seaborn or matplotlib have broken the functionality of ydata-profiling we have decided to analyze case by case the versions that we support.
We can consider upgrading seaborn, but we will need to define an upper version.
|
Would you be okay with upper pin on latest (0.13.2) provided tests pass? |
Signed-off-by: ggydush <[email protected]>
Signed-off-by: ggydush <[email protected]>
|
Yes totally! That would do. Tests are now running. |
fabclmnt
changed the title
fabclmnt
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1570 +/- ##
========================================
Coverage 90.19% 90.19%
========================================
Files 195 195
Lines 6394 6394
========================================
Hits 5767 5767
Misses 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for approving! Is there any chance this could be included in the next release? |
|
@fabclmnt you can merge, the lint error is a problem in the actions itself, that is already fixed in dev |
|
@ggydush yes this will be included for the next release. Probably either this week or beginning of the next. Thank you for your contribution. |
|
Any chance this could be released? |
Seaborn 0.13 fixes an issue with annotating heatmaps and I'd like to be able to use ydata-profiling in a repository that needs this fix.
I checked git blame and didn't see a reason for the upper-bound pin. I tested on 0.13.2 with Python 3.10 and all unit tests passed.