Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zero division for categorical colums with 100% missing data #1569

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

alexbarros
Copy link
Contributor

@alexbarros alexbarros commented Apr 3, 2024

Avoid error thrown when empty column is set as categorical with the type_schema

@alexbarros alexbarros requested a review from fabclmnt April 3, 2024 17:40
@alexbarros alexbarros force-pushed the fix/chisquare_zero_div branch from fe2ebda to 8f4d7a2 Compare April 3, 2024 17:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.19%. Comparing base (7612150) to head (52ad5ba).

Files Patch % Lines
...ata_profiling/model/pandas/describe_date_pandas.py 66.66% 2 Missing ⚠️
src/ydata_profiling/model/summary_algorithms.py 50.00% 2 Missing ⚠️
..._profiling/model/pandas/describe_boolean_pandas.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1569      +/-   ##
===========================================
- Coverage    90.25%   90.19%   -0.07%     
===========================================
  Files          195      195              
  Lines         6383     6394      +11     
===========================================
+ Hits          5761     5767       +6     
- Misses         622      627       +5     
Flag Coverage Δ
py3.8-ubuntu-22.04-pandas 90.19% <70.58%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexbarros alexbarros force-pushed the fix/chisquare_zero_div branch from 5526436 to 7884e2d Compare April 4, 2024 12:48
@alexbarros alexbarros merged commit 13522d0 into develop Apr 4, 2024
14 of 17 checks passed
@alexbarros alexbarros deleted the fix/chisquare_zero_div branch April 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants