Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1540 add_expectation_suite doesn't have key overwrite_existing #1541

Merged
merged 8 commits into from
May 31, 2024
+4 −2
Merged

fix: 1540 add_expectation_suite doesn't have key overwrite_existing #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bafe08f
fix:1540 add_expectation_suite doesn't have key overwrite_existing
einavfiterTB Feb 13, 2024
3c35c2d
Merge branch 'develop' into fix_1540
alexbarros Mar 12, 2024
256f9cf
Merge branch 'develop' into fix_1540
alexbarros Mar 13, 2024
49f2f5c
Merge branch 'develop' into fix_1540
fabclmnt May 1, 2024
df29bea
Merge branch 'develop' into fix_1540
fabclmnt May 6, 2024
00dc8c6
Merge branch 'develop' into fix_1540
fabclmnt May 6, 2024
e3e932a
Merge branch 'develop' into fix_1540
fabclmnt May 6, 2024
63dcce3
Update test_ge_integration.py
einavfiterTB May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ydata_profiling/expectations_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ def to_expectation_suite(
if not data_context:
data_context = ge.data_context.DataContext()

suite = data_context.add_expectation_suite(suite_name, overwrite_existing=True)
suite = data_context.add_expectation_suite(
suite_name
)

# Instantiate an in-memory pandas dataset
batch = ge.dataset.PandasDataset(self.df, expectation_suite=suite)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_ge_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_to_expectations_suite_title(context, df):
)

context.add_expectation_suite.assert_called_once_with(
"expectations-dataset", overwrite_existing=True
"expectations-dataset"
)


Expand Down
Loading