fix: infer all Numeric vars as TimeSeries when tsmode=True
#1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardodcpereira
approved these changes
May 23, 2023
aquemy
approved these changes
May 23, 2023
alexbarros
force-pushed
the
fix/tsmode_all_numerical_as_ts
branch
3 times, most recently
from
74ee2c3 to
8bac59f
Compare
alexbarros
force-pushed
the
fix/tsmode_all_numerical_as_ts
branch
from
8bac59f to
3869dd1
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #1343 +/- ##
===========================================
- Coverage 89.91% 89.89% -0.02%
===========================================
Files 191 191
Lines 6110 6099 -11
===========================================
- Hits 5494 5483 -11
Misses 616 616
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
aquemy
pushed a commit
that referenced
this pull request
May 24, 2023
* fix: infer all numericals as ts when tsmode=True * fix: adjust unit tests * fix: ts typeset allowing constant values
aquemy
pushed a commit
that referenced
this pull request
May 24, 2023
* fix: infer all numericals as ts when tsmode=True * fix: adjust unit tests * fix: ts typeset allowing constant values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the time dependence check for time series type inference