fix: comparison bugs #1137
Merged
fix: comparison bugs #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
reviewed
Nov 8, 2022
src/pandas_profiling/report/presentation/flavours/html/templates/alerts.html
Show resolved
Hide resolved
|
Oh, and in addition to the inline review: if bugs are being fixed, shouldn't there be tests to verify them? |
Codecov ReportBase: 89.94% // Head: 89.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/report-comparison #1137 +/- ##
==========================================================
- Coverage 89.94% 89.42% -0.52%
==========================================================
Files 177 177
Lines 5220 5258 +38
==========================================================
+ Hits 4695 4702 +7
- Misses 525 556 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aquemy
approved these changes
Nov 9, 2022
alexbarros
added a commit
that referenced
this pull request
Nov 18, 2022
* fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test
alexbarros
added a commit
that referenced
this pull request
Nov 18, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
alexbarros
added a commit
that referenced
this pull request
Nov 19, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
vascoalramos
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
aquemy
pushed a commit
that referenced
this pull request
Nov 22, 2022
* ci: check for flake8 comprehensions * fix(config): configuration order is now respected * fix: index is no longer automatically added to dataframe * feat: correlation alerts show the name of the correlation * fix: strip tags from the title of the web report * feat: comparing two or more datasets (see docs) * docs(comparison): feature description * docs(readme): include reference to the dataset comparison use case * refactor: config private attribute * refactor: config update, exclude defaults * refactor: include style attribute in timeseries code * refactor: include style attribute in templates * test(comparisons): add tests for report comparison * refactor: overall correlation lowercase * refactor: frequency table kwargs * refactor: frequency table styling * refactor: fixing renderable tests * refactor: fixing renderable tests * style: formatting * refactor: senstive test * refactor: pass style argument * feat: check for empty dataframe * refactor: namespace invariant type check * refactor: ipywidgets fixes * refactor: ipywidgets no comparison support yet * refactor: process feedback * fix: comparison bugs (#1137) * fix: refactoring bugs * fix: update protected var labels for comparison * fix: add support to timeseries comparison * fix: style changes for readability * test: add simple run test * fix: reword comparison report doc (#1136) * fix: rewording Co-authored-by: Aarni Koskela <[email protected]> * feat: add comparison validations (#1143) * feat: add comparison validations * feat: replace missing plots to avoid dependencies' confilicts (#1148) * feat: add new missing histogram plot * feat: add new missing matrix plot * feat: add new missing heatmap plot * feat: remove dendrogram * feat: ignore columns not present on the base report (#1150) * feat: select only the left side of the comparison * chore: pre-commit fixes * fix: not intersection of columns * [skip ci] Code formatting * fix: missing plots columns order * [skip ci] Code formatting * fix: interactions/missing plot colors * fix: code formatting Co-authored-by: Aarni Koskela <[email protected]> Co-authored-by: Azory YData Bot <[email protected]> Co-authored-by: alexbarros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs (most likely caused by refactoring) and added support to time series comparison
