Skip to content

Commit

Permalink
fix: linter recommendations update
Browse files Browse the repository at this point in the history
  • Loading branch information
Fabiana Clemente authored and Fabiana Clemente committed May 7, 2024
1 parent bf54ed7 commit 43db959
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/ydata_profiling/utils/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ def convert_timestamp_to_datetime(timestamp: int) -> datetime:
return datetime(1970, 1, 1) + timedelta(seconds=int(timestamp))


def analytics_features(dataframe, datatype: str, report_type: str):
def analytics_features(dataframe: str, datatype: str, report_type: str) -> None:
endpoint = "https://packages.ydata.ai/ydata-profiling?"

if os.getenv("YDATA_PROFILING_NO_ANALYTICS") != True:
if bool(os.getenv("YDATA_PROFILING_NO_ANALYTICS")) is not True:
package_version = __version__

try:
Expand Down
4 changes: 2 additions & 2 deletions src/ydata_profiling/utils/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ def __init__(self, name, level=logging.INFO):
super().__init__(name, level)

def info_def_report(self, dataframe, timeseries: bool):
if dataframe == pd.DataFrame:
if dataframe is pd.DataFrame:
dataframe = "pandas"
report_type = "regular"
elif dataframe == type(None):
elif dataframe is type(None):
dataframe = "pandas"
report_type = "compare"
else:
Expand Down
2 changes: 1 addition & 1 deletion src/ydata_profiling/visualisation/plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ def _plot_acf_pacf(

for ax in axes:
for item in ax.collections:
if type(item) == PolyCollection:
if type(item) is PolyCollection:
item.set_facecolor(color)

return plot_360_n0sc0pe(config)
Expand Down

0 comments on commit 43db959

Please sign in to comment.