Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cookie): Include Cookie Name as Env Var #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(cookie): Include Cookie Name as Env Var #21

wants to merge 5 commits into from

Conversation

wsalles
Copy link
Contributor

@wsalles wsalles commented Feb 23, 2022 •
edited by jira bot
Loading

closes PLT-296

@wsalles wsalles self-assigned this Feb 23, 2022
renatoaguimaraes
renatoaguimaraes suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@renatoaguimaraes renatoaguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create the AuthServiceConfiguration and share across the service? What do you think?

internal/configurations/rest_controller_configuration.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/controllers/rest_controller.go Outdated Show resolved Hide resolved
internal/handlers/cookie_credentials_handler.go Outdated Show resolved Hide resolved
internal/configurations/cookie_credentials_handler_configuration.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Feb 23, 2022
View reviewed changes
internal/configurations/authservice_configuration.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@wsalles wsalles requested a review from portellaa February 23, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portellaa portellaa Awaiting requested review from portellaa

@renatoaguimaraes renatoaguimaraes Awaiting requested review from renatoaguimaraes

At least 1 approving review is required to merge this pull request.

Assignees

@wsalles wsalles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsalles @portellaa @renatoaguimaraes