[Infra][Flaky Test Fix] Failing test: Single Host Flyout Tabs Metadat…

…a Tab should render metadata tab, add and remove filter (elastic#191745)
yctercero · Aug 30, 2024 · fbbed11 · fbbed11
1 parent 0a99955
commit fbbed11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...lution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx b/...lution/infra/public/components/asset_details/tabs/metadata/add_metadata_filter_button.tsx
@@ -90,7 +90,7 @@ export const AddMetadataFilterButton = ({ item }: AddMetadataFilterButtonProps)
   }
 
   return (
-    <span>
+    <span data-test-subj={`infraAssetDetailsMetadataField.${item.name}`}>
       <EuiToolTip
         content={i18n.translate('xpack.infra.metadataEmbeddable.setFilterByValueTooltip', {
           defaultMessage: 'Filter by value',

diff --git a/x-pack/test/functional/page_objects/asset_details.ts b/x-pack/test/functional/page_objects/asset_details.ts
@@ -180,7 +180,9 @@ export function AssetDetailsProvider({ getService }: FtrProviderContext) {
     },
 
     async clickAddMetadataFilter() {
-      return testSubjects.click('infraAssetDetailsMetadataAddFilterButton');
+      // Make this selector tied to the field to avoid flakiness
+      // https://github.com/elastic/kibana/issues/191565
+      return testSubjects.click('infraAssetDetailsMetadataField.host.name');
     },
 
     async clickRemoveMetadataFilter() {