Properly closing </sheetPr> when writing xl/worksheets/sheet*.xml
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @retostauffer , I fear that the pull request is based on an incorrect assumption. The duplicated sheetPr tag needs to be removed, not closed. Otherwise Excel will not be able to open the file. At least that's what I do in openxlsx2 and that's tested with Excel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear dev team,
writing issue #403 seems to have sorted my thoughts and I was able to track down the problem (what I think the problem is). This pull request fixes the problem with the minimal (see #403) and does not break the tests.
Thanks for all your work and all best,
R