Allow deregistering a section more than once

ycombinator · Jun 29, 2016 · 01cf4c5 · 01cf4c5
1 parent a9013a5
commit 01cf4c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/src/ui/public/management/__tests__/section.js b/src/ui/public/management/__tests__/section.js
@@ -76,17 +76,10 @@ describe('ManagementSection', () => {
       expect(section.items).to.have.length(0);
     });
 
-    it ('can only deregister a section once', () => {
-      let threwException = false;
+    it ('allows deregistering a section more than once', () => {
       section.deregister('about');
-
-      try {
-        section.deregister('about');
-      } catch (e) {
-        threwException = e.message.indexOf('is not registered') > -1;
-      }
-
-      expect(threwException).to.be(true);
+      section.deregister('about');
+      expect(section.items).to.have.length(0);
     });
 
   });

diff --git a/src/ui/public/management/section.js b/src/ui/public/management/section.js
@@ -55,9 +55,6 @@ export default class ManagementSection {
   * @param {string} id
   */
   deregister(id) {
-    if (!this.hasItem(id)) {
-      throw new Error(`'${id}' is not registered`);
-    }
     this.items.remove(item => item.id === id);
   }