Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace useExternalLinkAsNewTab() with remark-external-links #543

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Replace useExternalLinkAsNewTab() with remark-external-links #543

merged 2 commits into from
Jul 5, 2021

Conversation

ybiquitous
Copy link
Owner

@ybiquitous ybiquitous commented Jul 5, 2021 •
edited
Loading

https://github.com/remarkjs/remark-external-links

useExternalLinkAsNewTab() has side effects, it is flaky:

homepage/src/utils/useExternalLinkAsNewTab.js

Line 16 in 4e4e7a3

const externalLinks = Array.from(document.querySelectorAll("a[href^='http']")).filter(

@ybiquitous ybiquitous merged commit cb934e0 into main Jul 5, 2021
@ybiquitous ybiquitous deleted the remark-external-links branch July 5, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ybiquitous