-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppImage: folders and some files don't open when double clicked #20
Comments
The only reason I can think why this happens is because by not having a default application set xdg-open will probably do nothing at all. But pretty sure it's because Mint uses its own xdg implementation hidden behind xdg-open, so if possible to fix this I would need to check if the file opening succeeded and then if not use other implementations like Mint's one |
Does the folder open if you type "xdg-open /full/path/to/folder"? |
Yes, they open fine with xdg-open. |
Okay so we can exclude xdg-open implementations, I wonder if it's a permission problem or something else, in the next version I will try to implement a messagebox that pops up if the opening failed reporting the error, so you can report it here. I will let you know when I've implemented the messagebox! |
Maybe I will start a VM with Mint too |
Note that pictures and videos both open. My video player is SMPlayer and picture viewer is Nomacs, both sandboxed by firejail (symlinked to firejail in /usr/local/bin/) I didnt sandbox Nemo or Xed, which don't work. |
BTW despite these problems thanks for making this program, its the fastest GUI file searching tool I've used. |
It seems distros based on Ubuntu have their own xdg-open too, maybe first trying that and then falling back to xdg-open in case it does not work would be a good idea 🤔 |
Booted Mint in a VM to check this, got this error: Works on .deb, does not work in AppImage, I will contact the AppImage creator, it's either an AppImage problem or xed doing something badly. I recommend you to use the .deb until this gets fixed by them. |
Thanks, the deb version works without issue when opening files and folders with xed and nemo. Also, you might want to change the name of the binary that goes into /usr/bin/ because drill is another program from a package that is available in the repositories, just in case other people have it installed so it doesn't conflict. Maybe change the /usr/bin/ binary to drill-gtk |
I don't know what to do with this, it truly seems an AppImage bug exporting the wrong environment variables |
@probonopd any news about this? |
I'm starting to believe the real culprit here is Python, |
Linux Mint is the only distro that gave me problems with AppImage |
@probonopd The problem is that when a user finds a txt file on Linux Mint and double clicks it on Drill I open the file using |
So it seems like That's where my knowledge about this ends |
Sorry, from your description I can't follow you. Can you describe, step-by-step, how to reproduce the issue using, e.g., linuxmint-19.1-cinnamon-64bit.iso? |
It's a problem with directories also, not just text files. Steps to reproduce: |
|
@yatima1460 That appimage doesn't launch at all.
|
The fact that only Linux Mint has problems really makes me think about the entire distro not following Linux standards. |
I'm not too sure about that... |
Looks like the AppImage is seriously broken if it tries to open stuff from
|
@probonopd found a part of the problem Creating the AppImage using pkg2appimage with a local .deb file results in a broken AppImage Previously creating the AppImage manually worked, so first part of the problem is with pkg2appimage The second part is still the AppImage exporting the wrong variables and not being able to run |
you can check the recipe here: https://github.com/yatima1460/Drill/blob/master/Tools/AppImage/Drill_GTK.yml |
@pizzadude can you test the new AppImage? |
It launches, and I can search for stuff, but it has the same problem opening text files and folders as before. However, I noticed something. If I have xed already open, and try to open a text file, the text file opens. If xed is not open, it doesn't work and I get the encodings error. |
If you can't fix this that's okay with me as the deb version works fine. |
Can you explain in one post what "wrong variables" are being exported so that I don't have to read through the whole long thread? Thanks. Likely you need to change the AppRun file or replace it with a custom launcher script. |
@probonopd I will try to make a minimal AppImage that causes this bug |
Try this version, now I use gnome-open first if it's available instead of xdg-open. |
gnome-open is deprecated it seems.
|
From version 1.245 I can't open folders, or some files. Other files (jpg) open flawlessly. |
@daviddoc I know what causes this and it's very interesting, I now do that Drill first prefers the file opener of the system, like But it's funny how I think I will revert this change 🤔 |
I confirm it happens only with the combination of AppImage + xed So it's not a Linux Mint bug, but actually xed being complete garbage Any other text editor works flawlessly with AppImages I installed xed on Fedora, set it as default text editor, with the binary it works, with the AppImage xed crashes
when calling with Drill:
The reason is probably xed using a global environment variable to launch (bad design) and at the same time the AppImage exporting a wrong one or something, pretty cursed |
Please see AppImage/AppImageKit#396 |
btw i don't use mint cinnamon anymore, been using fedora kde for over a month and drill works fine on it... ...but this bug should probably still be fixed in case there's another mint cinnamon user in this universe who downloads this |
This still bugs me to this day |
@probonopd so any updates? Can I close this as not related to Drill? |
So I cannot reproduce the issue. (Maybe I don't understand what the issue is.) Note that the |
@probonopd The issue is when |
Try a custom |
Linux distro
Linux Mint 19.1 Cinnamon
Build Version
1.131
Describe the bug
In Linux Mint 19.1 Cinnamon (which uses Nemo file manager) double clicking a directory does nothing, but opening files such as videos and pictures works. Opening .txt files does nothing also. In Mint, xed is the default text editor.
To Reproduce
Steps to reproduce the behavior:
Try to open a txt file or directory with default applications.
Expected behavior
Double clicking a directory should open with nemo, opening a text file should open with xed.
The text was updated successfully, but these errors were encountered: