Skip to content

Commit

Permalink
test: fixing flake. (envoyproxy#11507)
Browse files Browse the repository at this point in the history
This is one of those cases where we actually want delay-close: we are doing a large upload, Enovy sends a response, and we want to make sure the socket stays open long enough the response is received rather than short delay-close causing a connection reset during upload

Risk Level: n/a (test only)
Testing: indeed
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: yashwant121 <[email protected]>
  • Loading branch information
alyssawilk authored and yashwant121 committed Jul 24, 2020
1 parent ac0f2b8 commit c23ab60
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -96,6 +96,13 @@ TEST_P(BufferIntegrationTest, RouterRequestPopulateContentLengthOnTrailers) {
}

TEST_P(BufferIntegrationTest, RouterRequestBufferLimitExceeded) {
// Make sure the connection isn't closed during request upload.
// Without a large drain-close it's possible that the local reply will be sent
// during request upload, and continued upload will result in TCP reset before
// the response is read.
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) { hcm.mutable_delayed_close_timeout()->set_seconds(2000 * 1000); });
config_helper_.addFilter(ConfigHelper::smallBufferFilter());
initialize();

0 comments on commit c23ab60

Please sign in to comment.