Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#519] FIX: Fix path of screenshot and pagesource #525

Merged

Conversation

cshimm
Copy link
Contributor

@cshimm cshimm commented Apr 26, 2024

Resolves #519

Allows user to open screenshots and pagesources in most browsers and text editors.

video1081266069.mp4

Edale Miguel and others added 4 commits April 22, 2024 15:27
Update the configuration to log the screenshot and page source file p…
This method will format local file paths into clickable URIs. Handles
paths in both Windows and Unix based paths.
@cshimm cshimm marked this pull request as ready for review April 29, 2024 22:45
@yashaka yashaka merged commit 92570f0 into yashaka:master May 15, 2024
5 of 7 checks passed
github-actions bot added a commit that referenced this pull request May 15, 2024
* Update the configuration to log the screenshot and page source file path correctly for all OS types

* prefix variable added. formatted prefix as 'file://'

---------

Co-authored-by: Edale Miguel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path of screenshot and pagesource on failure – should be windows friendly
2 participants