Skip to content

Commit

Permalink
DOCS: add more examples of custom conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
yashaka committed Apr 22, 2022
1 parent 6dbd317 commit 0a5a5b6
Show file tree
Hide file tree
Showing 3 changed files with 197 additions and 0 deletions.
Empty file added examples/__init__.py
Empty file.
189 changes: 189 additions & 0 deletions examples/custom_conditions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,189 @@
# MIT License
#
# Copyright (c) 2015-2022 Iakiv Kramarenko
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.

from selene import Browser, have
from selene.core.condition import Condition
from selene.core.conditions import ElementCondition, BrowserCondition
from selene.core.entity import Element
from selene.support.shared import browser


def have_produced_todos(number: int) -> Condition[Element]:
def fn(entity: Element) -> None:
size = len(browser.all("#todo-list>li"))
produced_enough = size >= number
if not produced_enough:
entity.type('one more').press_enter()
raise AssertionError(f'actual produced todos were: {size}')

return ElementCondition(f'have produced {number} todos', fn)


def test_wait_for_produced_todos_v1():
browser.open('http://todomvc.com/examples/emberjs/')
browser.element('#new-todo').should(have_produced_todos(3))


def produced_todos(number: int) -> Condition[Browser]:
def fn(entity: Browser) -> None:
size = len(browser.all("#todo-list>li"))
produced_enough = size >= number
if not produced_enough:
entity.element('#new-todo').type('one more').press_enter()
raise AssertionError(f'actual produced todos were: {size}')

return BrowserCondition(f'have produced {number} todos', fn)


def test_wait_for_produced_todos_v2():
browser.open('http://todomvc.com/examples/emberjs/')
browser.wait.for_(produced_todos(3))


def test_wait_for_notification_after_reload_v1():
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

def assert_action_successful_on_reload(entity):
browser.element('[href*=notification_message]').click()

if not browser.element('#flash').matching(have.exact_text('Action successful\n×')):
raise AssertionError('wrong message received')

browser.wait.for_(assert_action_successful_on_reload)


def test_wait_for_notification_after_reload_v2():
"""
more descriptive implementation
with custom rendering of error message on failure
"""
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

def assert_action_successful_on_reload(entity):
browser.element('[href*=notification_message]').click()
notification = browser.element('#flash')
webelement = notification()
actual = webelement.text
expected = 'Action successful\n×'

if actual != expected:
raise AssertionError(
f'notification message was wrong:'
f'\texpected: {expected}'
f'\t actual: {actual}'
)

browser.wait.for_(assert_action_successful_on_reload)


def test_wait_for_notification_after_reload_v3():
"""
more descriptive implementation
with custom rendering of error message on failure
with condition parameter - a text of message to receive
with a bit cleaner custom condition description in the log on failure
(by default the condition name
would be more low level default python fn representation)
wrapping condition as fn into class like BrowserCondition
– also allows to use some extra built-in feature s
like BrowserCondition.or_, .and_, etc.
here we also use the condition parameter - entity,
- that should be browser
if condition was called on a browser object
"""
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

def notification_on_reload(message: str) -> BrowserCondition:
def fn(entity: Browser):
entity.element('[href*=notification_message]').click()
notification = entity.element('#flash')
webelement = notification()
actual = webelement.text
expected = message

if actual != expected:
raise AssertionError(
f'notification message was wrong:'
f'\texpected: {expected}'
f'\t actual: {actual}'
)

return BrowserCondition(
f'received message {message} on reload',
fn,
)

browser.wait.for_(
notification_on_reload('Action successful\n×')
.or_(notification_on_reload('Action unsuccesful, please try again\n×'))
)


def test_wait_for_notification_after_reload_v4():
"""
with default rendering (built into selene's condition) of error message on failure
"""
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

def assert_action_successful_on_reload(entity):
browser.element('[href*=notification_message]').click()
have.exact_text('Action successful\n×')(browser.element('#flash'))

browser.wait.for_(assert_action_successful_on_reload)


def test_wait_for_notification_after_reload_v5():
"""
with default rendering (built into selene's condition) of error message on failure
AND simplified syntax with lambdas
"""
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

browser.wait.for_(lambda _: (
browser.element('[href*=notification_message]').click(),
have.exact_text('Action successful\n×')(browser.element('#flash')),
))


def test_wait_for_notification_after_reload_v6():
"""
with default rendering (built into selene's condition) of error message on failure
and simplified syntax with lambdas
AND with optimised performance and removed potential side effects of "nested waiting"
"""
browser.open('https://the-internet.herokuapp.com/notification_message_rendered')

browser.wait.for_(lambda _: (
browser.element('[href*=notification_message]')().click(),
have.exact_text('Action successful\n×')(browser.element('#flash')),
))
'''
notice how we called `().click()` instead of `.click()` on notification element
extra parenthesis allows to get actual webelement
that has not implicit waiting for click to be passed
by this - we ensure that there will be no nested waiting
in addition to "outher" `browser.wait.for`
'''
8 changes: 8 additions & 0 deletions selene/core/condition.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ def raise_if_not(
def fn(entity: E) -> None:
if not predicate(entity):
raise ConditionNotMatchedError()
# TODO: consider the following style as one more option:
#
# @condition(description) # or: @Condition.describe(description)
# def fn(entity: E) -> None:
# if not predicate(entity):
# raise ConditionNotMatchedError()
#
# return fn

return cls(description, fn)

Expand Down

0 comments on commit 0a5a5b6

Please sign in to comment.