Fix support for private GitHub shortcuts deps #971

ramasilveyra · 2016-10-13T07:48:32Z

Summary

Fix support for private GitHub shortcuts deps. See #573

Test plan

Only works with shortcuts:

"private-test": "github:ramasilveyra/private-test#d6c5789"
"private-test": "ramasilveyra/private-test#d6c5789"

I tried to follow the same name convention of npm/hosted-git-info for the "urls".

I found that npm first tries the git:// (info.git()) url then the git@... (info.ssh()) url then the https:// (info.https()) url and finally the git+ssh://... (info.sshurl()) url: npm/npm@6b0f588

Also what do you think about using this package to support the same repository urls for Github, Bitbucket and Gitlab as npm? It could solve a couple of incompatibility issues.

To make it work with this urls needs a little of more work on the GitResolver:

"private-test": "git://github.com/ramasilveyra/private-test.git#d6c5789"
"private-test": "[email protected]:ramasilveyra/private-test.git#d6c5789"
"private-test": "git+https://github.com/ramasilveyra/private-test.git#d6c5789"
"private-test": "git+ssh://[email protected]/ramasilveyra/private-test.git#d6c5789"

Update
yarn v0.16.0 actually works with:

"private-test": "git+ssh://[email protected]/ramasilveyra/private-test.git#d6c5789"

iddan · 2016-10-13T09:05:38Z

Much needed!

palnes · 2016-10-13T09:46:42Z

Go on, little pull request. you can do it!

sjmueller · 2016-10-16T03:19:39Z

I want to use yarn too! Can't wait til this one is merged :)

danielkcz · 2016-10-18T12:19:37Z

Exactly. This is currently only issue that is holding me back from embracing Yarn fully :)

danielkcz · 2016-10-18T12:46:23Z

src/resolvers/exotics/hosted-git-resolver.js

@@ -71,6 +71,11 @@ export default class HostedGitResolver extends ExoticResolver {
    throw new Error('Not implemented');
  }

+  static getGitSSH(exploded: ExplodedFragment): string {
+    exploded;
+    throw new Error('Not implemented');


What is actually the purpose of this? Why would you add call to this function and just throw an error in it?

That is what it does on all the methods of HostedGitResolver (src/resolvers/exotics/hosted-git-resolver.js) https://github.com/ramasilveyra/yarn/blob/efd9801987ef395a6a5ed30b3bc5e0cef94326b5/src/resolvers/exotics/hosted-git-resolver.js#L58-L84
I think that is for dev assurance for when you extend the class HostedGitResolver.

bestander · 2016-10-18T14:09:44Z

@ramasilveyra, that is quite awesome but how about a couple of new tests?

hzoo · 2016-10-18T20:13:53Z

@bestander would the tests be in package-resolver.js? Looks like they are commented out atm

yarn/__tests__/package-resolver.js

Lines 17 to 18 in 5ce30e8

    
           // TODO renable these test.concurrent 
        
           xit(`resolve ${pattern}`, async () => {

ramasilveyra · 2016-10-18T20:20:50Z

@bestander today EOD arg time I will try to add tests. But anyway if someone is eager and want to add it, prs to the branch fix-private-git-packages on my fork are welcome.

ramasilveyra · 2016-10-19T04:04:45Z

@bestander

Tests added!

Could you create a dummy private dep onhttps://github.com/yarnpkg/private-dep and give access to that to CircleCI, AppVeyor and TravisCI? Also I need the commit-ish. Thanks!

ramasilveyra · 2016-10-19T04:35:12Z

@hzoo I tried to enable it. But addTest('github:PolymerElements/paper-elements', 'bower'); // github url always fails, even on master. Maybe is that.

danielkcz · 2016-10-19T05:48:41Z

Looks like that version 0.16 already works with private repositories, so this might be obsolete.

ramasilveyra · 2016-10-19T06:14:32Z

@FredyC Tried with yarn v0.16.0 and private github shortcuts without success :(

Could you provide an example?

ramasilveyra · 2016-10-19T06:15:24Z

@FredyC Just found that yarn v0.16.0 actually works with "private-test": "git+ssh://[email protected]/ramasilveyra/private-test.git#d6c5789" that is good!

danielkcz · 2016-10-19T06:24:36Z

Yea, looks like it doesn't like variant with semicolon, found out about that too, but some packages are still failing for me. I have all private packages at GitLab.

danielkcz · 2016-10-19T12:51:06Z

@ramasilveyra Can you perhaps rebase to master? I would like to actually check this PR in action if it solves anything from my current issues.

trashhalo · 2016-10-19T18:43:38Z

out of date again. and whats the deal with the appveyor failure?

yarn install
'node' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

ramasilveyra · 2016-10-19T18:46:59Z

@trashhalo appveyor is broken for all. From de discord server #general:

Daniel15 - Today at 3:44 AM
@CMDR willyb321 On AppVeyor, you can download and install the msi if Chocolatey doesn't have the newest version (currently we're waiting for the Chocolatey team to approve 0.16.0)
https://www.appveyor.com/docs/how-to/download-file/ you can download https://yarnpkg.com/latest.msi using one of those methods, then msiexec /qn to install it.

Branch updated again :) cc @FredyC

bestander · 2016-10-28T13:48:22Z

Thanks for waiting, I am ready to merge this.
So what is the state of this feature?
@ramasilveyra could you rebase on master and explain how what feature it adds compared to fixes in 0.16?

bestander · 2016-10-28T13:45:36Z

__tests__/package-resolver.js

@@ -12,6 +12,7 @@ import * as fs from '../src/util/fs.js';
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 60000;

 const path = require('path');
+const isCI = require('is-ci');


bestander

rebase

ramasilveyra · 2016-10-28T15:13:06Z

@bestander branch rebased.

Remember that now the __tests__/package-resolver.js has some tests for private deps. We need a dummy private dep on https://github.com/yarnpkg/private-dep and give access to that to CircleCI, AppVeyor and TravisCI and also replace the commit ish on lines 62 and 63:
https://github.com/yarnpkg/yarn/pull/971/files#diff-acf7209ee8a640217777103218222465R62

Also the tests of package-resolver.js for some reason are disabled. Do you know why?

This feature adds support for private GitHub shortcuts ("private-test": "github:ramasilveyra/private-test#d6c5789" or "private-test": "ramasilveyra/private-test#d6c5789").
v0.16 only supports private deps in this form: "private-test": "git+ssh://[email protected]/ramasilveyra/private-test.git#d6c5789".

ramasilveyra · 2016-10-31T14:54:26Z

Closed because support was added by #1081 and It's getting complicated to keep this pr updated with master.

Update
I was wrong #1081 didn't fix the issue.

psyrendust · 2017-03-08T00:28:20Z

@ramasilveyra Did this ever get resolved for private GitHub shortcuts deps? I'm wondering based on your last comment: #971 (comment)

I'm using yarn version 0.21.3 and I'm still having issues. I'm getting the following error with 2 private repos hosted on github, which works fine with npm:

"contextual-search": "westfield/contextual-search#v1.3.2",
"maps-cw-fixtures": "westfield/maps-cw-fixtures#v0.1.0",

Trace: 
  Error: Error connecting to repository. Please, check the url.
      at /usr/local/Cellar/yarn/0.21.3/libexec/lib/node_modules/yarn/lib/resolvers/exotics/hosted-git-resolver.js:162:15
      at next (native)
      at step (/usr/local/Cellar/yarn/0.21.3/libexec/lib/node_modules/yarn/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
      at /usr/local/Cellar/yarn/0.21.3/libexec/lib/node_modules/yarn/node_modules/babel-runtime/helpers/asyncToGenerator.js:28:13
      at process._tickCallback (internal/process/next_tick.js:103:7)

I've even tried the ~./ssh/config hack listed here: #513 (comment)

anonrig · 2017-04-04T20:17:24Z

I'm having the same issue. Since I have 2FA enabled in Github I have to use git+ssh on my private github repos. I'm getting Error connecting to repository. Please, check the url. error. Anybody have any solution? Or is this a big lack of feature provided by Yarn itself?

nickfujita · 2017-04-12T21:00:29Z

@psyrendust @anonrig Were either of you able to get this working for private git repos? I also have 2FA enabled on github.

anonrig · 2017-04-13T00:15:18Z

I shouldn't and forced to use NPM unfortunately. @nickfujita

psyrendust · 2017-04-13T06:37:54Z

@nickfujita No, I'm not able to get this working with my orgs private repo's. I'm also using 2FA.

MiguelMadero · 2017-04-13T10:57:21Z

We use 2fa and private repos and it works using ssh and the full URI

…

On Thu, Apr 13, 2017 at 1:38 AM Larry Gordon ***@***.***> wrote: @nickfujita <https://github.com/nickfujita> No, I'm not able to get this working with my orgs private repo's. I'm also using 2FA. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5HK6oOq71mpMN4p6YXan4ISTOd2kkks5rvcLLgaJpZM4KVlPt> .

ramasilveyra · 2017-05-06T06:42:07Z

FYI just tested the version from master, and looks like the support for private git repos (with shorted syntax) works great!

Kudos for @thedumbterminal #2992 💥

It was released on v0.24.0: https://github.com/yarnpkg/yarn/releases/tag/v0.24.0

ramasilveyra force-pushed the fix-private-git-packages branch 2 times, most recently from 0b9d1b5 to 1c9d898 Compare October 15, 2016 01:20

ramasilveyra force-pushed the fix-private-git-packages branch from 1c9d898 to 9f4699b Compare October 17, 2016 00:57

ramasilveyra changed the title ~~Fix support for private git urls~~ Fix support for private github urls Oct 17, 2016

ramasilveyra changed the title ~~Fix support for private github urls~~ Fix support for private GitHub urls Oct 17, 2016

ramasilveyra changed the title ~~Fix support for private GitHub urls~~ Fix support for private GitHub shortcuts urls Oct 17, 2016

ramasilveyra changed the title ~~Fix support for private GitHub shortcuts urls~~ Fix support for private GitHub shortcuts deps Oct 17, 2016

BryanCrotaz mentioned this pull request Oct 17, 2016

git+ssh package install does not seem to work #513

Closed

ramasilveyra force-pushed the fix-private-git-packages branch from 9f4699b to efd9801 Compare October 18, 2016 00:53

chicoxyzzy mentioned this pull request Oct 18, 2016

Cannot ready property 'endsWidth' of undefined #699

Closed

danielkcz reviewed Oct 18, 2016

View reviewed changes

ramasilveyra force-pushed the fix-private-git-packages branch 2 times, most recently from 3860996 to 2790d04 Compare October 19, 2016 04:01

ramasilveyra force-pushed the fix-private-git-packages branch 4 times, most recently from 532afda to 0d3deef Compare October 19, 2016 04:30

ramasilveyra force-pushed the fix-private-git-packages branch from 0d3deef to bffb986 Compare October 19, 2016 05:11

ramasilveyra force-pushed the fix-private-git-packages branch from bffb986 to 85cd1f7 Compare October 19, 2016 15:23

ramasilveyra force-pushed the fix-private-git-packages branch from 85cd1f7 to 4b620d8 Compare October 19, 2016 18:46

ramasilveyra force-pushed the fix-private-git-packages branch 2 times, most recently from 8bf83d7 to 864ad07 Compare October 24, 2016 06:41

ramasilveyra force-pushed the fix-private-git-packages branch 3 times, most recently from 5681b82 to 7e73e44 Compare October 27, 2016 02:20

bestander approved these changes Oct 28, 2016

View reviewed changes

bestander self-assigned this Oct 28, 2016

bestander requested changes Oct 28, 2016

View reviewed changes

ramasilveyra force-pushed the fix-private-git-packages branch from 7e73e44 to a5e631d Compare October 28, 2016 14:48

Fix support for private GitHub shortcuts deps. Fix yarnpkg#573

b0c741c

ramasilveyra force-pushed the fix-private-git-packages branch from a5e631d to b0c741c Compare October 28, 2016 15:58

ramasilveyra closed this Oct 31, 2016

ramasilveyra deleted the fix-private-git-packages branch October 31, 2016 14:54

martynchamberlin mentioned this pull request Nov 1, 2016

Install from private github url #573

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix support for private GitHub shortcuts deps #971

Fix support for private GitHub shortcuts deps #971

ramasilveyra commented Oct 13, 2016 •

edited

Loading

iddan commented Oct 13, 2016

palnes commented Oct 13, 2016

sjmueller commented Oct 16, 2016

danielkcz commented Oct 18, 2016

danielkcz Oct 18, 2016

ramasilveyra Oct 18, 2016 •

edited

Loading

bestander commented Oct 18, 2016

hzoo commented Oct 18, 2016

ramasilveyra commented Oct 18, 2016 •

edited

Loading

ramasilveyra commented Oct 19, 2016 •

edited

Loading

ramasilveyra commented Oct 19, 2016

danielkcz commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016 •

edited

Loading

danielkcz commented Oct 19, 2016

danielkcz commented Oct 19, 2016

trashhalo commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016 •

edited

Loading

bestander commented Oct 28, 2016

bestander Oct 28, 2016

bestander left a comment

ramasilveyra commented Oct 28, 2016 •

edited

Loading

ramasilveyra commented Oct 31, 2016 •

edited

Loading

psyrendust commented Mar 8, 2017

anonrig commented Apr 4, 2017

nickfujita commented Apr 12, 2017

anonrig commented Apr 13, 2017

psyrendust commented Apr 13, 2017

MiguelMadero commented Apr 13, 2017 via email

ramasilveyra commented May 6, 2017 •

edited

Loading

Fix support for private GitHub shortcuts deps #971

Fix support for private GitHub shortcuts deps #971

Conversation

ramasilveyra commented Oct 13, 2016 • edited Loading

iddan commented Oct 13, 2016

palnes commented Oct 13, 2016

sjmueller commented Oct 16, 2016

danielkcz commented Oct 18, 2016

danielkcz Oct 18, 2016

Choose a reason for hiding this comment

ramasilveyra Oct 18, 2016 • edited Loading

Choose a reason for hiding this comment

bestander commented Oct 18, 2016

hzoo commented Oct 18, 2016

ramasilveyra commented Oct 18, 2016 • edited Loading

ramasilveyra commented Oct 19, 2016 • edited Loading

Tests added!

ramasilveyra commented Oct 19, 2016

danielkcz commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016 • edited Loading

danielkcz commented Oct 19, 2016

danielkcz commented Oct 19, 2016

trashhalo commented Oct 19, 2016

ramasilveyra commented Oct 19, 2016 • edited Loading

bestander commented Oct 28, 2016

bestander Oct 28, 2016

Choose a reason for hiding this comment

bestander left a comment

Choose a reason for hiding this comment

ramasilveyra commented Oct 28, 2016 • edited Loading

ramasilveyra commented Oct 31, 2016 • edited Loading

psyrendust commented Mar 8, 2017

anonrig commented Apr 4, 2017

nickfujita commented Apr 12, 2017

anonrig commented Apr 13, 2017

psyrendust commented Apr 13, 2017

MiguelMadero commented Apr 13, 2017 via email

ramasilveyra commented May 6, 2017 • edited Loading

ramasilveyra commented Oct 13, 2016 •

edited

Loading

ramasilveyra Oct 18, 2016 •

edited

Loading

ramasilveyra commented Oct 18, 2016 •

edited

Loading

ramasilveyra commented Oct 19, 2016 •

edited

Loading

ramasilveyra commented Oct 19, 2016 •

edited

Loading

ramasilveyra commented Oct 19, 2016 •

edited

Loading

ramasilveyra commented Oct 28, 2016 •

edited

Loading

ramasilveyra commented Oct 31, 2016 •

edited

Loading

ramasilveyra commented May 6, 2017 •

edited

Loading