Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-install cached artifacts. #805

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Don't re-install cached artifacts. #805

merged 1 commit into from
Oct 27, 2016

Conversation

yunxing
Copy link
Contributor

@yunxing yunxing commented Oct 12, 2016 •
edited
Loading

#804

This patch makes sure that if we load a package from cache, we don't install it again.

Test Plan

yarn add ocamlRe
rm -rf node_modules
yarn add ocamlRe

@yunxing yunxing force-pushed the cache branch 4 times, most recently from 4f30c67 to 934a250 Compare October 13, 2016 20:28
@sebmck
Copy link
Contributor

sebmck commented Oct 14, 2016

Can you please rebase

@bestander
Copy link
Member

ping @yunxing, this needs a rebase

@yunxing
Copy link
Contributor Author

yunxing commented Oct 20, 2016

sorry just saw this. Rebasing now

Don't re-install cached artifacts.
c3c9de9 
This patch makes sure if we load a package from cache, we don't install it again.
@yunxing yunxing merged commit 5e2fbe6 into master Oct 27, 2016
@samccone samccone deleted the cache branch October 27, 2016 01:02
@hpurmann hpurmann mentioned this pull request Nov 16, 2016
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestander bestander bestander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunxing @sebmck @bestander