Quote command so paths with whitespace work #663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the project is in a path with whitespace (
/Users/bleh/My Stuff/project/
), running binaries (yarn run eslint
) doesn't work. I quotedcmd
to solve this issue.A better way to solve this could be passing cmd and args separately down to
child.js
sspawn()
and quoting or escaping there, but that would require too much API change.Comments?
Test plan
Reproduce: