Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote command so paths with whitespace work #663

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Oct 11, 2016

Summary

If the project is in a path with whitespace (/Users/bleh/My Stuff/project/), running binaries (yarn run eslint) doesn't work. I quoted cmd to solve this issue.

A better way to solve this could be passing cmd and args separately down to child.jss spawn() and quoting or escaping there, but that would require too much API change.

Comments?

Test plan

Reproduce:

mkdir "some dir"
cd "some dir"
git clone [email protected]:yarnpkg/yarn.git
cd yarn
yarn
yarn run eslint

@bestander bestander merged commit e169535 into yarnpkg:master Oct 11, 2016
@nodesocket
Copy link

nodesocket commented Oct 12, 2016

Seems this commit broke yarn run command arg1 arg2.

See: issue 733

@AlicanC AlicanC deleted the alicanc-whitespace branch October 12, 2016 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants