test(pkg-tests): Fix duplicate module errors from pkg-tests #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Adds pkg-tests-fixtures to module ignore path for Jest to avoid duplicate module errors during test runs. **Test plan** Run `yarn test-only --clearCache; yarn test-only` and make sure you don't see any `duplicate @providesModule` errors from pkg-tests folder.
|
Yep 👍 Have you saw a pkg-tests spec failed? |
arcanis
approved these changes
Apr 10, 2018
Nope, everything seems fine. |
This was referenced Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds pkg-tests-fixtures to module ignore path for Jest to avoid duplicate module errors during test
runs.
Test plan
Run
yarn test-only --clearCache; yarn test-onlyand make sure youdon't see any
duplicate @providesModuleerrors from pkg-tests folder.