move e2e test to circle-ci #5459
Conversation
|
@Daniel15 Can you check if this is going into the right direction, I managed to get first test pass. It works for ubuntu 16.04. |
|
I'm about to go to sleep but I'll add this to my list of things to look at
tomorrow! :)
…--
Regards,
Daniel Lo Nigro
https://dan.cx/ | Twitter <http://twitter.com/Daniel15> | Facebook
<http://www.facebook.com/daaniel>
On Mon, Mar 5, 2018 at 11:33 PM, Rubycut ***@***.***> wrote:
@Daniel15 <https://github.com/daniel15> Can you check if this is going
into the right direction, I managed to get first test pass. It works for
ubuntu 16.04.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5459 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHY_z4exuuskhwv0FQ6EQQbNi2za5ks5tbjvAgaJpZM4SeOvF>
.
|
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| # Starts an Ubuntu 16.04 Docker container and runs the Yarn end-to-end test on it | |||
| set -ex | |||
| ./data/start-ubuntu.sh ubuntu:16.04 | |||
| cd data | |||
| ./run-ubuntu.sh | |||
There was a problem hiding this comment.
Just call run-ubuntu.sh directly (in config.yml) rather than modifying this script. This script should remain as-is, as it's still useful when running the test suite on your own computer.
rubycut
force-pushed
the
e2e_circleci
branch
2 times, most recently
from
e611326 to
96b4f6c
Compare
|
@Daniel15 , all three ubuntu versions are added, script are intact so manually runnging them should still work. This looks ready to be merged. |
|
This looks great! Where do failures get published to? The current E2E tests have their results recorded at https://build.dan.cx/job/yarn-e2e/. |
|
@Daniel15 , I am not sure what you mean. If you merge this pull requests, e2e builds will run every night and results will be visible in circle-ci. |
|
What do you think, @Daniel15 ? |
|
This looks good to me! Let's get this in 😃
@rubycut - What I mean is, how will we know that the tests have failed? With pull requests we see the CircleCI build status directly on the PR, with the current E2E tests they open a GitHub issue on failure. What happens if these ones fail? |
|
@Daniel15 I was assuming that you have some kind of notification setup in circleCI, this would allow you to get email when e2e tests fail. Let me know if there is anything else I can do. |
Summary
Move e2e test to circle-ci, Closing #4863
Test plan
This pull request is about tests, so we are not testing the tests.