Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary console output when running test cases #5384

Merged
merged 3 commits into from
Feb 23, 2018
Merged

Remove unnecessary console output when running test cases #5384

merged 3 commits into from
Feb 23, 2018

Conversation

sth
Copy link
Contributor

@sth sth commented Feb 21, 2018

Summary

Running the tests did, for some test cases, show yarn command output like [1/4] Resolving packages.... This pull request captures the command output instead of printing it to the console, the same way as this is done in many other test cases.

Unnecessary command output during testing makes the tests noisy. We are mostly only interested in test success or failure messages, not all the details of all the commands that run internally. Even if the command output were interesting, it usually should be captured and tested in the test, not written to console.

Test plan

The tests still pass, just with less random console output.

@arcanis
Copy link
Member

arcanis commented Feb 23, 2018

Makes sense, not sure why those tests specifically used a ConsoleReporter in the first place 🤔

@arcanis arcanis merged commit 559b5f2 into yarnpkg:master Feb 23, 2018
@sth sth deleted the tests-remove-console-output branch February 23, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants