feat(publish): Publish command uses publishConfig.access in package.json #5290
Conversation
For npm compatability, `yarn publish` should check `publishConfig.access` in package.json and use it as if the `--access` option was passed. yarnpkg#5279
|
This change will decrease the build size from 10.44 MB to 10.41 MB, a decrease of 29.77 KB (0%)
|
|
Test failures seem to be due to timeouts. I think this may be because the CI servers run without net access (tests pass when run locally). I probably need to mock something... will investigate/fix... |
|
Yeah, I think that's why publish wasn't tested until now - but if you find a way that would be great! |
__tests__/commands/publish.js
Outdated
|
|
||
| test.concurrent('publish should default access to undefined', () => { | ||
| return runPublish([], {newVersion: '0.0.1'}, 'minimal', config => { | ||
| const requestCallParams = config.registries.npm.request.mock.calls[0][1]; |
There was a problem hiding this comment.
I find it more readable to use toBeCalledWith rather than reaching into the mock objects
There was a problem hiding this comment.
I wasn't sure if there was a way to do that and only specify the parameter that I care about.
There was a problem hiding this comment.
or rather, the 2nd parameter is an object with a bunch of properties but I'm realy only testing 1 of them.
There was a problem hiding this comment.
It seems I had to nest a couple expect.objectContaining() calls, but I cleaned it up (or made it longer and more nested, depending on your point of view 😄 )
|
@arcanis it turns out it was prompting me for my npm password. Locally I was already logged it so it was getting skipped. I just mocked out the function so it always thinks I'm logged in, which skips the prompt and lets the tests pass. except for appveyor which seems to just be taking forever... |
|
Niiiice 👍 |
…readdir_files * upstream/master: (34 commits) feat(upgrade, add): Separately log added/upgraded dependencies (yarnpkg#5227) feat(publish): Publish command uses publishConfig.access in package.json (yarnpkg#5290) fix(CLI): Use process exit instead of exitCode for node < 4 (yarnpkg#5291) feat(cli): error on missing workspace directory (yarnpkg#5206) (yarnpkg#5222) feat: better error when package is not found (yarnpkg#5213) Allow scoped package as alias source (yarnpkg#5229) fix(cli): Use correct directory for upgrade-interactive (yarnpkg#5272) nohoist baseline implementation (yarnpkg#4979) 1.4.1 1.4.0 Show current version, when new version is not supplied on "yarn publish" (yarnpkg#4947) fix(install): use node-gyp from homebrew npm (yarnpkg#4994) Fix transient symlinks overriding direct ones v2 (yarnpkg#5016) fix(auth): Fixes authentication conditions and logic with registries (yarnpkg#5216) chore(package): move devDeps to appropriate place (yarnpkg#5166) fix(resolution) Eliminate "missing peerDep" warning when dep exists at root level. (yarnpkg#5088) fix(cli): improve guessing of package names that contain a dot (yarnpkg#5102) (yarnpkg#5135) feat(cli): include notice with license when generating disclaimer (yarnpkg#5072) (yarnpkg#5111) feat(cli): group by license in licenses list (yarnpkg#5074) (yarnpkg#5110) feat(cli): improve error message when file resolver can't find file (yarnpkg#5134) (yarnpkg#5145) ...
fixes #5279
Summary
For npm compatibility,
yarn publishshould checkpublishConfig.accessin package.json and use it as if the--accessoption was passed.If
--accessis also passed, then the command line parameter takes precedence.Test plan
Added unit tests regarding "access" in
__tests__/commands/publish.js