Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help comment to --json flag #5045

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Conversation

rally25rs
Copy link
Contributor

@rally25rs rally25rs commented Dec 5, 2017

fixes #5021

Summary

Added a help line to the commander output for the --json flag.

I didn't see any mention of --json on the website docs (nor are any of the "use anywhere" flags really documented) so I didn't make any changes there.

@rally25rs rally25rs requested a review from Haroenv December 5, 2017 20:11
Copy link
Member

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rally25rs rally25rs merged commit b2d3e1a into yarnpkg:master Dec 5, 2017
@rally25rs rally25rs deleted the json-flag-help branch December 5, 2017 21:26
@Daniel15
Copy link
Member

Daniel15 commented Dec 6, 2017

Thanks!

agoldis pushed a commit to agoldis/yarn that referenced this pull request Dec 18, 2017
…readdir_files

* upstream/master:
  fix(cli): Write Node4+ error message to stderr (yarnpkg#5094)
  test(jest): Upgrade jest to latest available version (yarnpkg#5018)
  fix(git): Ignores irrelevant output from ls-remote (yarnpkg#5081)
  test(integration): Fix failing react-scripts test due to unexpected
warning (yarnpkg#5076)
  feat(help) Add command descriptions to commander output (yarnpkg#5033)
  ci(circle): Fix cache key setup for proper node_modules sharing
(yarnpkg#5060)
  fixed (yarnpkg#5034)
  fix(fetcher): offline mirror name collision w/ private registries and
scopes (yarnpkg#4822)
  fix(add): Make semver flags compatible with versioned requests (yarnpkg#4999)
  [yarnpkg#5021] Add help comment to --json flag (yarnpkg#5045)
  fix(git): match git dependencies by name instead of whole url
  fix(install): connectionOptions passes in localhost as its host to
prevent popup on MacOsx. (yarnpkg#5006)
  chore(eslint): ignore packages dir (yarnpkg#4963)
agoldis pushed a commit to agoldis/yarn that referenced this pull request Dec 18, 2017
…readdir_files

* upstream/master:
  fix(cli): Write Node4+ error message to stderr (yarnpkg#5094)
  test(jest): Upgrade jest to latest available version (yarnpkg#5018)
  fix(git): Ignores irrelevant output from ls-remote (yarnpkg#5081)
  test(integration): Fix failing react-scripts test due to unexpected
warning (yarnpkg#5076)
  feat(help) Add command descriptions to commander output (yarnpkg#5033)
  ci(circle): Fix cache key setup for proper node_modules sharing
(yarnpkg#5060)
  fixed (yarnpkg#5034)
  fix(fetcher): offline mirror name collision w/ private registries and
scopes (yarnpkg#4822)
  fix(add): Make semver flags compatible with versioned requests (yarnpkg#4999)
  [yarnpkg#5021] Add help comment to --json flag (yarnpkg#5045)
  fix(git): match git dependencies by name instead of whole url
  fix(install): connectionOptions passes in localhost as its host to
prevent popup on MacOsx. (yarnpkg#5006)
  chore(eslint): ignore packages dir (yarnpkg#4963)
agoldis pushed a commit to agoldis/yarn that referenced this pull request Dec 18, 2017
…readdir_files

* upstream/master:
  fix(cli): Write Node4+ error message to stderr (yarnpkg#5094)
  test(jest): Upgrade jest to latest available version (yarnpkg#5018)
  fix(git): Ignores irrelevant output from ls-remote (yarnpkg#5081)
  test(integration): Fix failing react-scripts test due to unexpected
warning (yarnpkg#5076)
  feat(help) Add command descriptions to commander output (yarnpkg#5033)
  ci(circle): Fix cache key setup for proper node_modules sharing
(yarnpkg#5060)
  fixed (yarnpkg#5034)
  fix(fetcher): offline mirror name collision w/ private registries and
scopes (yarnpkg#4822)
  fix(add): Make semver flags compatible with versioned requests (yarnpkg#4999)
  [yarnpkg#5021] Add help comment to --json flag (yarnpkg#5045)
  fix(git): match git dependencies by name instead of whole url
  fix(install): connectionOptions passes in localhost as its host to
prevent popup on MacOsx. (yarnpkg#5006)
  chore(eslint): ignore packages dir (yarnpkg#4963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn outdated --json now prints invalid JSON
3 participants