chore(resolver): Minor improvements in resolver code and tests #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will decrease the build size from 9.91 MB to 9.91 MB, a decrease of 569 bytes (0%)
|
arcanis
approved these changes
Oct 6, 2017
| requestLevel += 1; | ||
| currentRequest = currentRequest.parentRequest; | ||
| } | ||
| this.level = requestLevel; |
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…kg#4644) * chore(resolver): Minor improvements in resolver code and tests **Summary** This is a follow up to yarnpkg#4484 and yarnpkg#4478 which improves the code around those areas a bit and removes a now-unnecessary `while` loop. **Test plan** Existing tests should pass. * Fix logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up to #4484 and #4478 which improves the code
around those areas a bit and removes a now-unnecessary
whileloop.
Test plan
Existing tests should pass.