Fix GitFetcher.fetchFromLocal using wrong hash #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcanis, this is for you to review |
arcanis
approved these changes
May 30, 2017
arcanis
requested changes
May 30, 2017
Following up yarnpkg#3449 expectHash is used beforehand to generate the cache destination, but actualHash is returned. This causes future cache destination path generation to use the wrong hash, resulting in EOENT errors.
Ngo-The-Trung
force-pushed
the
fix_mismatch_hash
branch
from
477c66e to
4fa7411
Compare
|
@arcanis fixed |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found on 0.25.3
Following up #3449
expectHash is used beforehand to generate the cache destination, but actualHash is returned. This causes future cache destination path generation to use the wrong hash, resulting in EOENT errors.
@bestander
Full story:
PackageFetcher generates
destparameter using Config.generateHardModulePath before fetching using expectHash i.e. the commit hashGitFetcher returns actualHash (i.e. tarball hash) as result of fetch
Some time later updateManifest is called with the fetch result hash (actualHash)
This pollutes the resolved patterns cache (PackageResolver.patterns) with the wrong hash (actualHash)
Future Config.generateHardModulePath calls getResolvedPattern and gets actualHash, (as opposed to expectHash. This causes it to look for the cached package in the wrong directory.