Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the enable-meta-folder #3367

Merged
merged 2 commits into from
May 10, 2017
Merged

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 10, 2017

Summary

The following PR adds an enable-meta-folder option. When active, the .yarn-integrity and yarn-error.log files will be written inside this folder rather than respectively inside node_modules and the cwd.

Test plan

I added a test to make sure the integrity file was correctly created.

@arcanis arcanis requested a review from bestander May 10, 2017 15:21
@voxsim
Copy link
Contributor

voxsim commented May 10, 2017

@arcanis why we don't just add a 'meta-folder' option instead of enabling it? And in case we do not specify it, we fallback to default option like we do in the global-folder

@voxsim
Copy link
Contributor

voxsim commented May 10, 2017

I am asking because maybe there are some reasons, I am curious :)

@arcanis
Copy link
Member Author

arcanis commented May 10, 2017

You mean allowing people to set the path to whatever they want? The meta folder is supposed to store only things related to the internals of Yarn, so I'm not convinced that we should give users the ability to choose where it's stored, the same way we don't let them choose how should be named the yarn.lock file.

@voxsim
Copy link
Contributor

voxsim commented May 10, 2017

Mmh but if someone does a link of the meta folder, isn't it the same?
If we don't want to allow people to set the path, why now do we give them a choice?

@bestander
Copy link
Member

bestander commented May 10, 2017

I think this is a good first step as is.
If it is going to be a part of someone's workflow and making the location configurable would make sense then let's just add that feature then.
Thanks for bringing it up, @voxsim.
Feel free to drive a discussion forward.

@bestander bestander merged commit 9809511 into yarnpkg:master May 10, 2017
arcanis added a commit that referenced this pull request May 12, 2017
* Implements the enable-meta-folder

* Adds enable-meta-folder support to yarn-error.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants