Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor informations to licences ls command #3292

Merged
merged 4 commits into from
May 3, 2017

Conversation

lochbrunner
Copy link
Contributor

Summary

No. It only adds two columns to the output of a reporting feature.

Often when using OpenSource Software one has to make a finer report of the used dependencies. For example Vendor/Author name and homepage is a must.
The current feature provided by yarn is nice, but still not sufficient for commercial use.

Test plan

I ran

yarn licenses ls --json > licenses.json

Results in a large json output. A cut of them looks like

{
    "type": "table",
    "data": {
        "head": [
            "Name",
            "Version",
            "License",
            "URL",
            "VendorUrl",
            "vendorName"
        ],
        "body": [
            [
                "ansi-regex",
                "2.1.1",
                "MIT",
                "https://github.com/chalk/ansi-regex.git",
                "sindresorhus.com",
                "Sindre Sorhus"
            ],
            [
                "aws-sign2",
                "0.6.0",
                "Apache-2.0",
                "https://github.com/mikeal/aws-sign",
                "http://www.futurealoof.com",
                "Mikeal Rogers"
            ],

@voxsim
Copy link
Contributor

voxsim commented May 1, 2017

Hey @lochbrunner that's a wonderful idea :D Could you please write some tests that do the same stuff that you do manually? If you need some help I am here ;)

@lochbrunner
Copy link
Contributor Author

Hi @voxsim,
by now, there are no tests for the licenses command at all. I will read into the tests for the list command and try to write some for the licenses command. Or did I overlooked it?

@voxsim
Copy link
Contributor

voxsim commented May 1, 2017

@lochbrunner you are right, that's why if for some reasons you find some difficulties I am here to help you. Can you help us? Do you have time? ;)

@lochbrunner
Copy link
Contributor Author

@voxsim, thanks for your support.
The yarn project is quite interesting and I want to understand its design and toolchain more detailed! But unfortunately not today, but tomorrow.

@lochbrunner
Copy link
Contributor Author

@voxsim is this ok?
Maybe one should increase the timeout for integration.js?

@voxsim
Copy link
Contributor

voxsim commented May 2, 2017

@lochbrunner it's perfect! awesome! :D Could you please call expected-table.json instead oftable.json?

@lochbrunner
Copy link
Contributor Author

@voxsim Done!

@voxsim
Copy link
Contributor

voxsim commented May 2, 2017

Let's wait for the result and merge it if everything is ok :)

@lochbrunner
Copy link
Contributor Author

What to do with the failed test run? It's a timeout issue.

@bestander bestander merged commit 0b3c443 into yarnpkg:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants